Use beatmap cache to populate beatmap information in tournament client #24037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Jun 25, 2023
| var req = new GetBeatmapRequest(new APIBeatmap { OnlineID = b.ID }); | ||
| API.Perform(req); | ||
| b.Beatmap = new TournamentBeatmap(req.Response ?? new APIBeatmap()); | ||
| b.Beatmap = new TournamentBeatmap(beatmapCache.GetBeatmapAsync(b.ID).GetAwaiter().GetResult() ?? new APIBeatmap()); |
There was a problem hiding this comment.
Is this GetAwaiter().GetResult() stuff an attempt to bypass the fact that .Result is banned? If yes, then did you try calling .GetResultSafely() which is a framework extension for this express purpose?
There was a problem hiding this comment.
yes, this should be my oversight, sorry
already fix
bdach
changed the title
|
This seems okay. But I did notice one other issue: if you're not logged in when this population process runs, it still attempts each and every request, but they all fail due to |
peppy
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many different tournaments, the beatmap information in the seedingBeatmaps of different teams is the same, because each team use the same set of seedingBeatmaps for seeding, and the cache should be used.
Can greatly speed up populate when the number of beatmap that should be requested is small and the team is large