Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviour of timing points in the editor #28752

Open
1 of 6 tasks
snalgae opened this issue Jul 6, 2024 · 5 comments
Open
1 of 6 tasks

Weird behaviour of timing points in the editor #28752

snalgae opened this issue Jul 6, 2024 · 5 comments
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@snalgae
Copy link

snalgae commented Jul 6, 2024

Type

Game behaviour

Bug description

Just messing around in the editor. I think the fact that the compose tab went blank when I pressed undo once made me notice this.
After some tinkering I actually discovered that there is weirdness related to timing points:
Bugs:

  • Cloning a timing point, removing the timing attribute, enabling an effect attribute and enabling kiai time, and then undoing makes a timing point without the yellow tick on the timeline, fixed after saving and reloading the beatmap
  • Undoing a timing point while in a compose tab deloads the compose tab (Fix composer disappearing when undoing change to control points #28776) and the yellow tick also disappears on an affected timing point.
  • Making a timing point using "+ Add at current time" when there's already another timing point, does not automatically update the bars. When you place it, it appears without the white thick bar lines and the timeline still uses the bars from the previous timing point (you need to wiggle the timeline or change attribute settings to make it update).
  • Skip bar line does not visually change the white bars, while the metronome sounds are affected as intended.

Unintuitive stuff:

  • The set up of attributes (enabling timing or effect) does not save them. So pressing ctrl+z skips the enabling of the attribute and affects an action before it. It also affects doing something inside of an attribute and then undoing back to the starting state of an attribute (like when you want to revert back to the original state for timing) . In that case it disables the attribute and can remove the timing point itself.
  • I was confused about the scrolling of the waveforms inside of the timing attribute because I thought the scrolling was vertical, but it actually scrolls horizontally.

I can make a video/screenshot of a specific issue on request if you need more information. I made one video for the second bug before discovering more issues.

Screenshots or videos

2024-07-06.21-36-16.mp4

Version

2024.625.2

Logs

compressed-logs.zip

@snalgae

This comment was marked as off-topic.

@bdach

This comment was marked as off-topic.

@snalgae

This comment was marked as off-topic.

@frenzibyte

This comment was marked as off-topic.

@snalgae

This comment was marked as off-topic.

bdach added a commit to bdach/osu that referenced this issue Jul 8, 2024
@peppy peppy added the priority:2 Moderately important. Relied on by some users or impeding the usability of the game label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
None yet
Development

No branches or pull requests

5 participants