Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composer disappearing when undoing change to control points #28776

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix composer disappearing when undoing change to control points #28776

merged 2 commits into from
Jul 8, 2024

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Jul 8, 2024

As mentioned in #28752.
Regressed in #28444.

@bdach bdach added area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! labels Jul 8, 2024
@bdach bdach mentioned this pull request Jul 8, 2024
Open
6 tasks
peppy
peppy approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was wondering if this would ever happen in practice 😄

@smoogipoo smoogipoo merged commit 9c2a057 into ppy:master Jul 8, 2024
15 of 17 checks passed
@bdach bdach deleted the fix-composer-disappearing branch July 9, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

@peppy peppy peppy approved these changes

Assignees
No one assigned
Labels
area:editor next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdach @peppy @smoogipoo