Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor playfield not being centered correctly #16327

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 5, 2022

This has come up multiple times, with mappers citing that they have muscle memory for mapping based on the centre of the playfield being in the centre of the window.

The original plan was to have a second toolbar on the right hand side of the screen to balance the padding, but we're not at that point yet. Easiest solution is to do what stable does and allow the left-hand toolbar items to overlap the playfield underneath it.

In edge cases where the user is running at an aspect ratio that causes overlaps, they can choose to collapse the toolbars down. We can probably work on this UI/UX a bit more as we update designs to be more friendly to such cases.

16:10 4:5
Before 20220105 160926 (osu!) 20220105 160918 (Safari)
After 20220105 160833 (osu!) 20220105 160807 (osu!)

This has come up multiple times, with mappers citing that they have
muscle memory for mapping based on the centre of the playfield being in
the centre of the window.

The original plan was to have a second toolbar on the right hand side of
the screen to balance the padding, but we're not at that point yet.
Easiest solution is to do what stable does and allow the left-hand
toolbar items to overlap the playfield underneath it.

In edge cases where the user is running at an aspect ratio that causes
overlaps, they can choose to collapse the toolbars down. We can probably
work on this UI/UX a bit more as we update designs to be more friendly
to such cases.
@bdach
Copy link
Collaborator

bdach commented Jan 5, 2022

The one worry I have is 4:3 aspect ratio, which is somewhat a thing of the past but I think there may still be people who use that - here's 1280x1024, for instance:

osu_2022-01-05_20-12-04

I'm not sure if there is any chance to get a hit object small enough wherein it can get stuck behind the toolboxes though, so maybe not a big deal? I'd think that most people will be using widescreen screens at this day and age, although it's always difficult to tell...

Going to tentatively approve but wait for a response to the above.

@peppy
Copy link
Member Author

peppy commented Jan 6, 2022

You can see something quite similar happening in stable at 5:4:

20220106 153526 (Parallels Desktop app)

I don't think this is of huge concern for now. As I said above, I'd rather improve the UX (having the ability from the side toolbar areas to retract into the side of the screen, or using tab to toggle them on/off completely) rather than adding special case logic to ensure no overlap.

Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I really agree with this but it is what it is...

@smoogipoo smoogipoo merged commit 1d69eb6 into ppy:master Jan 6, 2022
@peppy peppy deleted the fix-editor-playfield-centering branch January 7, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants