Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various editor design language (and centre playfield / timeline) #24220

Merged
merged 21 commits into from
Jul 21, 2023

Conversation

peppy
Copy link
Member

@peppy peppy commented Jul 14, 2023

Brings us closer to the figma designs. Also centres the playfield and timeline centre as proposed in #24207.

Before After
osu! 2021-09 at 10 49 13 osu! 2023-07-14 at 10 48 13

Comment on lines 64 to 69
text.AddText("osu!", t => t.Font = OsuFont.TorusAlternate);
text.AddText("editor", t =>
{
t.Font = OsuFont.TorusAlternate;
t.Colour = colourProvider.Highlight1;
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header is also present in the skin editor which may be confusing. I would rename it to beatmap/skin editor.

I also don't get why the prefixing of "osu!" in certain places is a thing (maybe just in the design mockups?). We had osu!news in the website for a while and osu!chat during the chat redesign PR before I renamed it in #18433 because of localisation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's supposed to give emphasis to certain game areas or features. Think of it as visual flair, not helpful text that needs to be localised.

In this case, I'd argue the header here should not be localised if it is to remain at all. As in, it should either be present as osu!editor on all languages, or be removed completely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does this fall in the "Services and applications" listed in https://osu.ppy.sh/wiki/en/Brand_identity_guidelines#osu!? If so, it is a proper noun and shouldn't be localised.

And as a proper noun, osu!editor can only be the beatmap editor or skin editor and not both. That is where my problem is.

I also feel like we are returning back to using osu! prefixes (like osu!direct but is now beatmap listing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah well osu!direct is another point of contention. most people know it by this branding so we may actually return to it.

osu.Game/Screens/Edit/Components/Menus/EditorMenuBar.cs Outdated Show resolved Hide resolved
@bdach
Copy link
Collaborator

bdach commented Jul 19, 2023

So, about the horizontal centering, time really is a flat circle... See #16327, then #23370.

Now we're back at "if the window is narrow enough, the playfield is partially obscured by tool areas":

osu_2023-07-19_20-02-49

And contrary to what we used to have at one point, collapsing the right toolboxes doesn't do much anymore, because they also take up width when collapsed.

The above screenshot is 1280x1024, i.e. 4:3 ratio. While it is slowly going away, I imagine some people may still be using 4:3 screens.

@peppy
Copy link
Member Author

peppy commented Jul 21, 2023

Now we're back at "if the window is narrow enough, the playfield is partially obscured by tool areas"

The thing about this is, even if the playfield is fully visible at these aspect ratios, mappers are going to complain about things like "I need to place slider control points outside of the visible area".

I think a better solution is adding zoom support. May look at that next.

@peppy
Copy link
Member Author

peppy commented Jul 21, 2023

I've fixed this zoom issue in a hopefully adequate way.

@bdach
Copy link
Collaborator

bdach commented Jul 21, 2023

mappers are going to complain about things like "I need to place slider control points outside of the visible area".

Maybe we could fade or entirely hide the toolbars during placement or something. Not sure.

Definitely not going to ask to address that in this pull, it's run its course already.

@bdach bdach enabled auto-merge July 21, 2023 17:11
@bdach bdach disabled auto-merge July 21, 2023 18:12
@bdach bdach merged commit e9c7684 into ppy:master Jul 21, 2023
peppy added a commit to peppy/osu that referenced this pull request Jul 26, 2023
Regressed with recent centering changes in ppy#24220
peppy added a commit to peppy/osu that referenced this pull request Jul 26, 2023
Regressed with recent centering changes in ppy#24220
@peppy peppy deleted the editor-metrics branch July 29, 2023 18:18
@tovc
Copy link

tovc commented Jun 25, 2024

The central red line is no longer directly above the centre of the playfield after today's update
osu_2024-06-25_19-54-05

@bdach
Copy link
Collaborator

bdach commented Jun 25, 2024

I'm honestly not convinced that detail is important, stable isn't centered either. The specific feedback was that people wanted to see more of the timeline.

@tovc
Copy link

tovc commented Jun 25, 2024

I personally thought it looked a lot better. I do understand having more of the timeline visible, and I do think that is a good change. I personally think that having the red line centered over the playfield would still be a reasonable option, even if it does result in the timeline being asymmetrical. Either that or just move the snapping options down a bit. There seems to be plenty of room for the latter choice

Stable has a lot of similar inconsistencies. Lazer's attention to detail is very much something that I admire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants