Fix osu!taiko editor playfield missing a piece #24374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regressed with recent centering changes in ppy#24220
peppy
force-pushed
the
fix-taiko-alignment
branch
from
9d4da15
to
deba6e2
Compare
bdach
requested changes
Jul 26, 2023
| /// <summary> | ||
| /// Whether the playfield should be centered vertically. Should be disabled for playfields which span the full horizontal width. | ||
| /// </summary> | ||
| protected virtual bool ApplyVerticalCentering => true; |
There was a problem hiding this comment.
Okay, first of all, this applies horizontal centering, and not vertical.
There was a problem hiding this comment.
Hmm. That depends how your brain works. But I think you're correct that that is the more accepted understanding.
There was a problem hiding this comment.
Not sure why this rename wasn't applied, but given that the above seems to be an agreement, I'll apply it myself to speed things up because god knows I'm review-backlogged to my ears already.
bdach
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed with recent centering changes in #24220