Improve group tracking logic to avoid switching which point type unnecessarily #18531
Conversation
There was a problem hiding this comment.
Incidentally this also fixes the issue I pointed out in #18502 (comment)
| // If the selected group has more than one control point, choose the first as the tracking type | ||
| // if we don't already have a singular tracked type. | ||
| else if (trackedType == null) | ||
| trackedType = selectedGroup.Value?.ControlPoints.FirstOrDefault()?.GetType(); |
There was a problem hiding this comment.
Side note - currently are only two possible control point types on this screen, and therefore, if there is more than one control point in the group, then all applicable types of control points are in the group.
If there are ever more, then this logic may lead to unexpected results. Imagine selecting a control point group with types [A, B], followed by selecting a group with types [C, D]. The first selection would cause the timing screen to start tracking A, but the second would not change tracking at all to either C or D (because there is more than one type in the group, and the tracked type is already set).
Not really worth fixing, just something that occurred in my mind in passing.
There was a problem hiding this comment.
Yeah, it's still best-effort. If we add more, I'd want the current selected "type" to show somewhere in the interface, and tracking be based on which you interacted with.
As pointed out by @smoogipoo , due to arbitrary parsing order, using the
.First()type could cause the tracked type to switch on beatmaps which have two types of control points at the same time location.Closes #18409