New beatmap information wedge design implementation

[mk56-spn]

Another step towards : #18890 being done.

Adds the updated wedge design ( exclusively as a test scene component for now, given it removes a large amount of information, which will be implemented in its own component, as such implementing it directly is unfeasible)

In the file I marked down two issues that are out of my control to fix, namely:

• The mismatched shadow type on the text ( to my knowledge diffused text shadows are not possible currently, given the text is a sprite instead of an SVG and there is no pre rendered diffused shadow i think)).

• And the fact that i have as of yet not heard back from Flyte on how to source the colours for the updated wedge background gradient ( https://www.figma.com/file/DXKwqZhD5yyb1igc3mKo1P?node-id=2980:3361#340801912 )

As a final note I plan to do the implementation of the playcount count present in the design separately if possible, due to it seeming to have more implementation detail than I'd expected.

[bdach]

A few basic things from just a visual inspection:

• The stars on the right don't seem to match - design has them centred vertically (and seems to round down to full stars), current implementation has them stuck to top
• As the background in the test is black, there's no way to even tell how this design will work with actual backgrounds
• The designs don't seem to have map status anywhere - you seem to have added them in an educated guess and it seems maybe fine, but input from designer-san would be appreciated if possible

[mk56-spn]

A few basic things from just a visual inspection:

* The stars on the right don't seem to match - design has them centred vertically (and seems to round down to full stars), current implementation has them stuck to top

* As the background in the test is black, there's no way to even tell how this design will work with actual backgrounds

* The designs don't seem to have map status anywhere - you seem to have added them in an educated guess and it seems maybe fine, but input from designer-san would be appreciated if possible

1: this is due to it being the old star counter design which has small stars going up to 10, instead of the new one which cuts off wherever it needs to, old design was left in after frenzy mentioned not being a big fan https://discord.com/channels/188630481301012481/188630652340404224/1049958910720737310 till further discussion is had.

2: black background isnt ideal i agree. will look into

3: yep, but i asked ppy on discord and he said if something is already there that isnt in the drafts it should generally be left there. https://discord.com/channels/188630481301012481/188630652340404224/1050002698885398528

[peppy]

prelim review there's a lot wrong

[peppy]

No, you really do not want to buffer the whole thing. Have you run the tests and looked at the quality of things in general? Using a buffered container on things like text causes texel misalignment and makes everything more blurry. There's a reason on the original info wedge it was only applied to the background.

You can work around this by using

Suggested change

	Child = bufferedContent = new BufferedContainer
	Child = bufferedContent = new BufferedContainer(pixelSnapping: true)

but note that if the wedge is ever moved around on the screen using a transform, this will cause it to look less smooth.

Keep in mind there's an inherent overhead with every usage of BufferedContainer, too.

[peppy]

@mk56-spn did you miss this feedback?

[mk56-spn]

@mk56-spn did you miss this feedback?

Nope. Working on a fix. Been a tad busy. All should be addressed and done within the day - 2days max

[mk56-spn]

fixed, i do see a path forward which does not require pixel snapping by separating the text and background into container only one of which is nested in the buffered container, i however did not opt for this since i felt that the pixel snapping look good here ( i tried it on the carousel to get a feel for the different applications and it look god awful because it can be moved by the user and it looked choppy as hell ) and benefited the wedge anyhow by making the line between the colourbar and the background less muddy

[peppy]

What?

This needs reconsideration (yes I know this is in the original code, but it cannot be blindly copied into a newer version).

[peppy]

This cannot.

[peppy]

and this? if you are unsure how to solve, please say so and I will look into a solution.

[mk56-spn]

and this? if you are unsure how to solve, please say so and I will look into a solution.

I am unsure but mainly I've been a bit busy for a couple of days. A hint would definitely be appreciated though

[peppy]

Put it this way: as a general rule, a drawable should not be interacting with the children of a nested drawable.

The most raw solution would be to fix rotation to work correctly (inside the StarCounter). Or make a new derived / new version of the star counter.

[mk56-spn]

should be fixed now

[Joehuu]

Have pushed changes to address most of the problems + code quality.

Here's a WIP branch with the wedge in-game (to test with how it behaves, not taking designs into account yet (i.e. width is longer, but is set in a grid container): master...Joehuu:osu:wedge-redesign

took over

[peppy]

This is looking pretty decent from a code perspective.

One remaining hope I have is to move the star rating out of the reloadable content so it doesn't awkwardly flash on beatmap change:

osu.Game.Tests.2023-09-05.at.07.00.50.mp4

Maybe the rank status can also be moved out (although it would require some consideration as to its animation, but that can come later).

[peppy]

As commented

[Joehuu]

Like this?

osu._1kfK00tuS8.mp4

The rolling is enabled because it would look bad without it (and it's not reconstructed every time anymore).

Moving the star rating display really improves code quality, so pushing the changes anyway soon.

[peppy]

Yep, that looks perfect.