Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New beatmap information wedge design implementation #22116

Merged
merged 44 commits into from
Sep 6, 2023
Merged

New beatmap information wedge design implementation #22116

merged 44 commits into from
Sep 6, 2023

Commits on Jan 10, 2023

  1. Remove info labels, since they are no longer present in this componen… 

    …t in thew new design
    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f561120 View commit details
    Browse the repository at this point in the history

  2. Move stardifficulty logic to main BeatmapInfoWedge class instead of t… 

    …ext subclass ( for use by background star rating colour bar )
    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c646f84 View commit details
    Browse the repository at this point in the history

  3. Add a test scene and move colour bar to back and adjust positioning o… 

    …f it
    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    0199c19 View commit details
    Browse the repository at this point in the history

  4. Add coloured star counter

    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    61caaba View commit details
    Browse the repository at this point in the history

  5. Simplify passing data from BeatmapInfoWedgeV2.cs to subclass wedgeinf… 

    …otext
    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    1698272 View commit details
    Browse the repository at this point in the history

  6. Remove nullability disabling

    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    65c30d2 View commit details
    Browse the repository at this point in the history

  7. small tweaks, container edge - effect addition..

    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    9afdfd7 View commit details
    Browse the repository at this point in the history

  8. Add TODO for text margin const, added pertinent comments to known "is… 

    …sues"
    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2a82f61 View commit details
    Browse the repository at this point in the history

  9. Remove nullable disable in test.

    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8bfe24c View commit details
    Browse the repository at this point in the history

  10. Fix margins on top right aligned elements.

    @mk56-spn
    mk56-spn committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8804280 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Add back null beatmap test

    @mk56-spn
    mk56-spn committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7510201 View commit details
    Browse the repository at this point in the history

  2. Address issues that joehuu brought up

    @mk56-spn
    mk56-spn committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    74b72e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Expose star difficulty to wedge to allow updating starcounter and bac… 

    …kground colour internally.
    @mk56-spn
    mk56-spn committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    0ac7cd7 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Buffer wedge content to avoid opacity issues when showing / hiding

    @mk56-spn
    mk56-spn committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    6552423 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Update BeatmapInfoWedgeV2.cs animation to be similar to exit tr… 

    …ansition in ```SongSelect.cs``
    @mk56-spn
    mk56-spn committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    c7d49bd View commit details
    Browse the repository at this point in the history

  2. de-nest removeOldInfo()

    @mk56-spn
    mk56-spn committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    92690af View commit details
    Browse the repository at this point in the history

  3. Use inline lambda for scheduling

    @mk56-spn
    mk56-spn committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    27c52a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Fix BeatmapInfoWedgeV2.cs starCounter needing janky rotation ap… 

    …plication
    @mk56-spn
    mk56-spn committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5fc8f1d View commit details
    Browse the repository at this point in the history

  2. enable pixelSnapping for the BufferedContainer in BeatmapInfoWe… 

    …dgeV2.cs
    @mk56-spn
    mk56-spn committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    de37a0a View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Remove IsPresent usages

    @mk56-spn
    mk56-spn committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    38cc47d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. Separate wedge visibility test into its own method

    @mk56-spn
    mk56-spn committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    cb679cc View commit details
    Browse the repository at this point in the history

  2. Separate ruleset changing tests into their own method. 

    Add small clarification for edge colouring in visibility test
    @mk56-spn
    mk56-spn committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    4684198 View commit details
    Browse the repository at this point in the history

  3. Clean up formatting and wedge placement in testscene a tad,

    @mk56-spn
    mk56-spn committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    09cb6ca View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Improve visibility of wedge shading in test scene and fix an issue wi… 

    …th excessive roundness on said shadow.
    @mk56-spn
    mk56-spn committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    299023f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Adjust shadow to look better

    @peppy
    peppy committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f21238f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Merge branch 'master' into beatmap_wedge_clean_ii

    @Joehuu
    Joehuu authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    2fbd67c View commit details
    Browse the repository at this point in the history

  2. Fix truncating sprite text usage

    @Joehuu
    Joehuu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    bf71099 View commit details
    Browse the repository at this point in the history

  3. Use right padding instead of negative x offset

    @Joehuu
    Joehuu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e8a7934 View commit details
    Browse the repository at this point in the history

  4. Move negative corner radius margin to constructor

    @Joehuu
    Joehuu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    2df2002 View commit details
    Browse the repository at this point in the history

  5. Move drawable and binding logic to standard places

    @Joehuu
    Joehuu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e70510e View commit details
    Browse the repository at this point in the history

  6. Simplify text initialization

    @Joehuu
    Joehuu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    82fb9dc View commit details
    Browse the repository at this point in the history

  7. Fix wedge showing abruptly in test

    @Joehuu
    Joehuu committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e0a9c7e View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Remove weird red edge effect visibility

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    854bb32 View commit details
    Browse the repository at this point in the history

  2. Fix star rating rolling counter regression

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9accd0d View commit details
    Browse the repository at this point in the history

  3. Fix star counter animating weird and delayed

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    98d027d View commit details
    Browse the repository at this point in the history

  4. Rename null beatmap test to indicate there's a background

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9451613 View commit details
    Browse the repository at this point in the history

  5. Remove buffered container (doesn't seem like it's doing anything anym… 

    …ore)
    @peppy
    peppy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a8c9c2b View commit details
    Browse the repository at this point in the history

  6. Fix test scene not updating all star counters

    @peppy
    peppy committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    340edf6 View commit details
    Browse the repository at this point in the history

  7. Remove buffered container comment 

    While it is true that there is a transparency overlap, it is only seen when entering/exiting song select. And there are other components game-wide that exhibit the same issue when transparency changes. Should be reconsidered another time.
    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6e6dd86 View commit details
    Browse the repository at this point in the history

  8. Remove mods dependency 

    BPM is not in the wedge anymore.
    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b63c1e4 View commit details
    Browse the repository at this point in the history

  9. Make beatmap non-nullable 

    Doesn't seem like it'll be null after first set: https://github.com/ppy/osu/blob/5454d1caa1927428fe339e3d5b47ddfe45f9dfb6/osu.Game/OsuGameBase.cs#L363
    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5becac6 View commit details
    Browse the repository at this point in the history

  10. Move actual star updating to star rating display

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    6762409 View commit details
    Browse the repository at this point in the history

  11. Move star rating display and status pill out of reloadable content

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3f92dae View commit details
    Browse the repository at this point in the history

  12. Fix left padding adding shear width

    @Joehuu
    Joehuu committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8e8fae0 View commit details
    Browse the repository at this point in the history