Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status icon design #22182

Merged
merged 4 commits into from
Jan 14, 2023
Merged

Update status icon design #22182

merged 4 commits into from
Jan 14, 2023

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Jan 13, 2023

Part of the user panel design update #22130

Before:
image

After:
image

Designs on figma look a bit more thick somehow, but according to figma the border thickness is the same (4px)

@Theighlin
Copy link

Sorry for posting this if you already know it or that isn't the problem here, but whenever i hear about pixel discrepancies with figma this comes to mind, have you already read it?

@jai-x
Copy link
Member

jai-x commented Jan 13, 2023

Should this new icon also be used in the login panel?

@stanriders
Copy link
Member Author

Sorry for posting this if you already know it or that isn't the problem here, but whenever i hear about pixel discrepancies with figma this comes to mind, have you already read it?

I don't think this is relevant here

Should this new icon also be used in the login panel?

I can't find the designs for the new login panel, so can't really be sure if it should be there or not. I can add it for consistency though

@stanriders stanriders mentioned this pull request Jan 13, 2023
3 tasks
osu.Game/Users/Drawables/StatusIcon.cs Outdated Show resolved Hide resolved
@bdach
Copy link
Collaborator

bdach commented Jan 13, 2023

Designs on figma look a bit more thick somehow, but according to figma the border thickness is the same (4px)

This is probably because designs have the icon in smaller sizes. I see 14x14 and 22x22, but with 4px borders everywhere while StatusIcon is using 25x25. Scaling on some higher level may also be fudging numbers.

I can't find the designs for the new login panel, so can't really be sure if it should be there or not. I can add it for consistency though

I'd agree with doing so to just keep one copy of everything. Should be relatively straightforward to just replace this:

Foreground.Add(statusIcon = new SpriteIcon
{
Anchor = Anchor.CentreLeft,
Origin = Anchor.CentreLeft,
Icon = FontAwesome.Regular.Circle,
Size = new Vector2(14),
});

@stanriders
Copy link
Member Author

stanriders commented Jan 13, 2023

This is probably because designs have the icon in smaller sizes. I see 14x14 and 22x22, but with 4px borders everywhere while StatusIcon is using 25x25.

StatusIcon on screenshots is 14x14 - I kept 25 as a default from the current user panel implementation

I'd agree with doing so to just keep one copy of everything.

Sure, I'll update it in a second

@peppy peppy merged commit 2f2ab44 into ppy:master Jan 14, 2023
@stanriders stanriders deleted the status-icon branch January 14, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants