Implement new design of Key Counter #22655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsShamed
force-pushed
the
gameplay/argon-key-counter_le-retour
branch
from
9205fff
to
809b817
Compare
|
This is super uninspiring visually but I'm just gonna get this in in a base state and figure things out animation wise later, probably when this is actually usable in the game. |
peppy
approved these changes
Apr 25, 2023
|
@ItsShamed are you planning to continue the implementation of this for reference? |
|
Yes, I initially planned to continue working on this PR but did not expect to be merged that fast. I was standing by waiting for further reviews and directions. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes and closes #22640
Depends on :
Related to #18888
This is just the component in itself for now.
osu.Game.Tests_Tpe6qj95jz.mp4