Add exact match support for song select searches

[peppy]

As requested at #24005 (reply in thread). Seemed like a quick one to add and quite beneficial QoL wise so knocked it out.

Of note, this could possibly be implemented in the following code block instead:

osu/osu.Game/Screens/Select/FilterQueryParser.cs

Lines 22 to 35 in a74547c

	internal static void ApplyQueries(FilterCriteria criteria, string query)
	{
	foreach (Match match in query_syntax_regex.Matches(query))
	{
	string key = match.Groups["key"].Value.ToLowerInvariant();
	var op = parseOperator(match.Groups["op"].Value);
	string value = match.Groups["value"].Value;
	if (tryParseKeywordCriteria(criteria, key, value, op))
	query = query.Replace(match.ToString(), "");
	}
	criteria.SearchText = query;
	}

Only noticed this after writing the version I did. Not sure if it makes more or less sense.

[peppy]

Please double check this during review. Currently this change forces all searches like artist="this artist" to exact mode. The quotes here were used to group the search to be scoped to artist, but not necessarily expecting exact match.

I think this seems fine, but worth double-checking with expectations.

[bdach]

Probably fine until proven otherwise.

[bdach]

I'm not sure... this works?

Shouldn't the second result not be there? Reading the relevant discussion that's what I'd say the user wants out of this feature.

[peppy]

Shouldn't the second result not be there? Reading the relevant discussion that's what I'd say the user wants out of this feature.

Hmm, I don't know about that. I implemented this based on the way quotations work in other search engines / contexts. But maybe for osu!'s context it's fine to change it to match the full context?

[bdach]

Why is this not just

Suggested change

	return Regex.IsMatch(value, $@"(^|\s){searchTerm}($|\s)", RegexOptions.IgnoreCase | RegexOptions.CultureInvariant);
	return value.Equals(searchTerm, StringComparison.OrdinalIgnoreCase);

What's the whitespace-or-string-{start,end} thing doing here?

[peppy]

because you don't want "you" to match "your"

[bdach]

Okay, so it won't match "your", but it might match "will you", or "you will", or whatever, because what it's trying to do is trying to test full word phrases rather than substrings.

Again, doesn't fix the problem with song with a title of just "you", as typing "you" will still match a bunch of things with the word "you" in it. It'll be some results less but I imagine still a lot. Probably fine though.

[bdach]

I implemented this based on the way quotations work in other search engines / contexts. But maybe for osu!'s context it's fine to change it to match the full context?

I'm not opposed to having it behave like search engines do, but I am confused by the OP claiming that this solves a need in the linked discussion that this change does not in fact appear to solve.

[peppy]

A good reason for matching standard implementation is because it's also supported in the same way in elasticsearch (aka beatmap listing and other online components).

We could probably add something similar to what the user suggests as a follow up for the specific case they want (ie. exact=), although obviously that won't work with title= prefixes so well. Another option would be double quotes or something equally custom.

[bdach]

After the initial confusion has been cleared up this looks to be working pretty well now that I've recalibrated my expectations. Pushed a few minor fixes (4cb122d is particularly important, as not escaping bare user input before putting it into a regex could lead to a runtime crash), but looks good otherwise. Please check though.