Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exact match support for song select searches #24045

Merged
merged 8 commits into from
Jun 27, 2023
Merged

Add exact match support for song select searches #24045

merged 8 commits into from
Jun 27, 2023

Commits on Jun 26, 2023

  1. Apply NRT to FilterCriteria

    @peppy
    peppy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    14c95f4 View commit details
    Browse the repository at this point in the history

  2. Add test coverage of exact matching of search terms

    @peppy
    peppy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    1960cd0 View commit details
    Browse the repository at this point in the history

  3. Add exact match support at song select

    @peppy
    peppy committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    a74547c View commit details
    Browse the repository at this point in the history

  4. Remove weird nullable enable and double licence header

    @bdach
    bdach committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8a7a42b View commit details
    Browse the repository at this point in the history

  5. Add failing test case for filters potentially crashing due to invalid… 

    … regex
    @bdach
    bdach committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    4873aaf View commit details
    Browse the repository at this point in the history

  6. Escape user input before embedding into regex

    @bdach
    bdach committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    4cb122d View commit details
    Browse the repository at this point in the history

  7. Use == true rather than ?? false

    @bdach
    bdach committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e998be0 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into exact-match-song-select

    @bdach
    bdach committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    9c30b1d View commit details
    Browse the repository at this point in the history