-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp results screen statistics display #24153
Draft
peppy
wants to merge
30
commits into
ppy:master
Choose a base branch
from
peppy:results-screen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+490
−341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)
This works well now until render scale is above 1. It used to work better on May need to re-think the implementation of relative -> absolute conversion here. Open to ideas. |
…e better visible results
…etter This also removes the vertical scroll container completely, simplifying the whole interaction of the results screen.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing for initial feedback. Still have a few tidying tasks before this is ready for merge.
This isn't intended to be a final design or even something matching flyte's newer designs. It's an initial effort to tidy up how statistics are provided and presented on the results screen. I've taken liberties in colour choice and positioning.
Todo: