Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp results screen statistics display #24153

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jul 7, 2023

PRing for initial feedback. Still have a few tidying tasks before this is ready for merge.

This isn't intended to be a final design or even something matching flyte's newer designs. It's an initial effort to tidy up how statistics are provided and presented on the results screen. I've taken liberties in colour choice and positioning.

Before After
osu! 2021-09 at 09 38 45 osu! 2023-07-07 at 09 49 32

Todo:

  • Fix vertical centering when ruleset is not providing a full grid of content
  • Fix UI scale breaking things at extremes (maybe a separate PR)

Weird "basal" height logic just didn't make any sense (was getting stuck at 1 when `DrawHeight` was 0)
@peppy
Copy link
Sponsor Member Author

peppy commented Jul 12, 2023

This works well now until render scale is above 1. It used to work better on mater for slightly higher than one scales, but eventually breaks there too.

May need to re-think the implementation of relative -> absolute conversion here. Open to ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result menu scrollable height dependent on parent position when opening
1 participant