Fix timing distribution graph sometimes not displaying correctly

osu.Game/Screens/Ranking/Statistics/HitEventTimingDistributionGraph.cs

@@ -211,7 +211,8 @@ private partial class Bar : CompositeDrawable
  private readonly bool isCentre;
  private readonly float totalValue;
 
- private float basalHeight;
+ private const float minimum_height = 0.02f;
+
  private float offsetAdjustment;
 
  private Circle[] boxOriginals = null!;
@@ -256,47 +257,42 @@ private void load()
  else
  {
  // A bin with no value draws a grey dot instead.
- Circle dot = new Circle
+ InternalChildren = boxOriginals = new[]
  {
- RelativeSizeAxes = Axes.Both,
- Anchor = Anchor.BottomCentre,
- Origin = Anchor.BottomCentre,
- Colour = isCentre ? Color4.White : Color4.Gray,
- Height = 0,
+ new Circle
+ {
+ RelativeSizeAxes = Axes.Both,
+ Anchor = Anchor.BottomCentre,
+ Origin = Anchor.BottomCentre,
+ Colour = isCentre ? Color4.White : Color4.Gray,
+ Height = 0,
+ }
  };
- InternalChildren = boxOriginals = new[] { dot };
  }
  }
 
  protected override void LoadComplete()
  {
  base.LoadComplete();
 
- if (!values.Any())
- return;
-
- updateBasalHeight();
+ float offsetValue = 0;
 
- foreach (var boxOriginal in boxOriginals)
+ for (int i = 0; i < boxOriginals.Length; i++)
  {
- boxOriginal.Y = 0;
- boxOriginal.Height = basalHeight;
- }
+ int value = i < values.Count ? values[i].Value : 0;
 
- float offsetValue = 0;
+  var box = boxOriginals[i];
 
- for (int i = 0; i < values.Count; i++)
- {
- boxOriginals[i].MoveToY(offsetForValue(offsetValue) * BoundingBox.Height, duration, Easing.OutQuint);
- boxOriginals[i].ResizeHeightTo(heightForValue(values[i].Value), duration, Easing.OutQuint);
- offsetValue -= values[i].Value;
+ box.Y = 0;
+ box.Height = 0;
+
+ box.MoveToY(offsetForValue(offsetValue) * BoundingBox.Height, duration, Easing.OutQuint);
+ box.ResizeHeightTo(heightForValue(value), duration, Easing.OutQuint);
+ offsetValue -= value;
  }
- }
 
- protected override void Update()
- {
- base.Update();
- updateBasalHeight();
+ if (boxAdjustment != null)
+ drawAdjustmentBar();
  }
 
  public void UpdateOffset(float adjustment)
@@ -324,43 +320,9 @@ public void UpdateOffset(float adjustment)
  drawAdjustmentBar();
  }
 
- private void updateBasalHeight()
- {
- float newBasalHeight = DrawHeight > DrawWidth ? DrawWidth / DrawHeight : 1;
-
- if (newBasalHeight == basalHeight)
- return;
+ private float offsetForValue(float value) => (1 - minimum_height) * value / maxValue;
 
- basalHeight = newBasalHeight;
- foreach (var dot in boxOriginals)
- dot.Height = basalHeight;
-
- draw();
- }
-
- private float offsetForValue(float value) => (1 - basalHeight) * value / maxValue;
-
- private float heightForValue(float value) => MathF.Max(basalHeight + offsetForValue(value), 0);
-
- private void draw()
- {
- resizeBars();
-
- if (boxAdjustment != null)
- drawAdjustmentBar();
- }
-
- private void resizeBars()
- {
- float offsetValue = 0;
-
- for (int i = 0; i < values.Count; i++)
- {
- boxOriginals[i].Y = offsetForValue(offsetValue) * DrawHeight;
- boxOriginals[i].Height = heightForValue(values[i].Value);
- offsetValue -= values[i].Value;
- }
- }
+ private float heightForValue(float value) => minimum_height + offsetForValue(value);
 
  private void drawAdjustmentBar()
  {