Fix column sizing exceeding screen width on tablets #25777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Dec 15, 2023
| if (RuntimeInfo.IsMobile) | ||
| { | ||
| // These numbers are based on mobile phones, aspect ~1.92. | ||
| float mobileAdjust = 2.83f * Math.Min(1, 7f / stageDefinition.Columns); |
There was a problem hiding this comment.
Is 2.83f anything? 1.92f is explained, but not this.
There was a problem hiding this comment.
ah, this is taken from the ratio applied in the previous version of this code (170 / 60).
bdach
approved these changes
Dec 15, 2023
bdach
added a commit
to bdach/osu
that referenced
this pull request
May 16, 2024
TextAdventurer12
pushed a commit
to TextAdventurer12/osu
that referenced
this pull request
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now applies to all skins. I removed the special column adjust because it'd be a bit hard to get right across different skins. Hopefully this doesn't throw people off too much (we could probably just adjust argon across all devices back to 1.8 if so?).
Intentionally not running on invalidation to keep things simple.
Closes #25440 (comment).