Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more usable osu!mania touch input system #28173

Merged
merged 11 commits into from
May 14, 2024

Conversation

peppy
Copy link
Member

@peppy peppy commented May 14, 2024

This takes smoogi's previous effort (#27790) and presents it in a state where it can be merged without skin configurability concerns. I've left the configurable settings in code for exposing in the future.

I've made changes to bring it more in line with how taiko's touch area system was implemented for conformity. The major change is that it no longer uses the presence of touch mod to decide whether to display (and can now be summoned using a mouse click or touch).

The drawable implementation here is copied verbatim. I'd probably make some visual touches but I don't want to dwell on this and would love to get this functional improvement in the next release to help the seemingly large number of osu!mania mobile lazer players.

2024-05-14.22.17.02.mp4

@bdach
Copy link
Collaborator

bdach commented May 14, 2024

If this is a thing, should we revert #25336 / #25777 while we're at it?

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine generally

@bdach bdach merged commit d52dffe into ppy:master May 14, 2024
13 of 17 checks passed
bdach added a commit to bdach/osu that referenced this pull request May 16, 2024
- Closes ppy#25852
- Reverts ppy#25336 /
  ppy#25777

With the columns not being directly touchable anymore after
ppy#28173 I see very little point to this
continuing to exist.
@Yushu2606
Copy link

This is very uncomfortable for players who originally play like Melody or Kalpa

@peppy peppy deleted the mania-touch-input-revised branch May 23, 2024 05:42
TextAdventurer12 pushed a commit to TextAdventurer12/osu that referenced this pull request Jul 6, 2024
- Closes ppy#25852
- Reverts ppy#25336 /
  ppy#25777

With the columns not being directly touchable anymore after
ppy#28173 I see very little point to this
continuing to exist.
@ThinLiquid
Copy link

ThinLiquid commented Oct 31, 2024

This is very uncomfortable for players who originally play like Melody or Kalpa

I found a work around...

  1. Use a skin with really large column widths (or modify one... I modified the Mobile Mania skin)
  2. Use the Horizontal scale setting (use the Gameplay scale mode) to adjust the skin's width to align with the touch area buttons

and now it feels somewhat like a regular mobile rhythm game!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants