Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash after changing audio track in editor #26219

Merged
merged 3 commits into from
Dec 29, 2023

Use alternative workaround

99cddb6
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix crash after changing audio track in editor #26219

Use alternative workaround
99cddb6
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed Dec 29, 2023 in 1s

Test Results (Windows, SingleThread) ❌

Tests failed

❌ TestResults-Windows-SingleThread.trx

5489 tests were completed in 1431s with 5436 passed, 1 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 16✔️ 1❌ 3s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✔️ TestConstructor
✔️ TestLeadInProducesCorrectStartTime(1000,0)
✔️ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✔️ TestLeadInProducesCorrectStartTime(2000,0)
✔️ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
❌ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -10000.0d +/- 100.0d
	  But was:  -9831.5141000000003d
	  Off by:   -168.48589999999967d
	
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

Annotations

Check failure on line 0 in TestResults-Windows-SingleThread.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -10000.0d +/- 100.0d
    But was:  -9831.5141000000003d
    Off by:   -168.48589999999967d
  
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -10000.0d +/- 100.0d
  But was:  -9831.5141000000003d
  Off by:   -168.48589999999967d

--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)