Fix slider tracking state not restoring correctly in all cases on rewind #27429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kind of scary this wasn't happening already. Mirrors `SpinnerRotationTracker`.
|
@smoogipoo have you had a chance to look at this one? i'm not so keen on the complexity added by this solution. i might take a look at whether i can find some other way if you agree. |
|
I don't think this is any more complex than I would have done it. |
smoogipoo
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. Intends to fix the primary failure described in #27177 (comment).
I'm not sure how to feel about the solution in general but as far as I can tell it does appear to function.