Add new footer back button and fix shearing being different between components #28183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes a test case in `TestSceneShearedButton`s to ensure the buttons' shear factors don't change on different heights (I've encountered issues with that previously).
When shear factors differ between components that are close to each other (`BackButtonV2` and `ScreenFooterButton` in this case), they look completely ugly.
1 task
peppy
reviewed
May 28, 2024
Comment on lines
+59
to
+60
| DarkerColour = Color4Extensions.FromHex("#DE31AE"); | ||
| LighterColour = Color4Extensions.FromHex("#FF86DD"); |
There was a problem hiding this comment.
I'm not 100% on these colours but will amend once things come together if they don't work.
peppy
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
One debatable part here is that I've had to make
ShearedButtonaccept different heights in order for the back button to match the reference design.This is probably an indicator that the footer will look bigger than most components of the screen as I mentioned before. I think it's best to leave the footer as-is until it is fully integrated with the mod overlay, at which point adjusting the footer's measurements would be an easy thing to do.