Add basic animation to new footer and buttons #28184
Conversation
| Size = new Vector2(BUTTON_WIDTH, BUTTON_HEIGHT); | ||
|
|
||
| Child = new Container | ||
| Child = TopLevelContent = new Container |
There was a problem hiding this comment.
I'm not huge on exposing this, but can live with it.
That said, having the animations applied by ScreenFooter directly on this is a no-go for me. I think that needs to be moved internally to the button class itself.
Also needs some commenting on why the animations are being applied to this container, not the button itself. I'm sure there's valid reasoning but it needs to be explicitly stated.
There was a problem hiding this comment.
I moved the animations inside of the button class as mentioned, and I've replaced TopLevelContent with just Content (which points to a local container since the button class inherits from ClickableContainer).
I'm not entirely sure if commenting is necessary though, the button class doesn't apply transitions on this anywhere else, and there's a precedent for this in ShearedButton, where Content is used to rescale the button instead of this, so that if there's a button next to this one all inside of a flow container, it won't move from its place.
…m base implementation instead The point is to apply the transitions against a container that's inside of `ScreenFooterButton`, because the `ScreenFooterButton` drawable's position is being controlled by the flow container it's contained within, and we cannot apply the transitions on it directly.
Preview:
CleanShot.2024-05-16.at.07.44.16.mp4
There are no animations defined anywhere in the reference designs so I rolled up my own. The intention of this PR is to at least have something there that can be tweaked.