Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix break generation not accounting for concurrent hitobjects correctly #28630

Merged
merged 5 commits into from
Jun 27, 2024

Add note about implicit reliance on sort by start time

b1baa49
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix break generation not accounting for concurrent hitobjects correctly #28630

Add note about implicit reliance on sort by start time
b1baa49
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Jun 27, 2024 in 0s

5851 passed, 19 failed and 52 skipped

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

5922 tests were completed in 1773s with 5851 passed, 19 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope 3✅ 1❌ 13s
osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModRelax 2✅ 1❌ 10s
osu.Game.Rulesets.Catch.Tests.TestSceneCatchModHidden 1✅ 1❌ 1s
osu.Game.Rulesets.Mania.Tests.Mods.TestSceneManiaModFadeIn 5✅ 1❌ 12s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModAutoplay 5✅ 1❌ 17s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModDifficultyAdjust 5✅ 1❌ 11s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight 12✅ 2❌ 24s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModNoScope 3✅ 1❌ 13s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSingleTap 4✅ 1❌ 14s
osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSpunOut 3✅ 3❌ 34s
osu.Game.Rulesets.Osu.Tests.TestSceneCursorParticles 1✅ 2❌ 22s
osu.Game.Tests.Visual.Gameplay.TestSceneFailJudgement 3✅ 2❌ 21s
osu.Game.Tests.Visual.Gameplay.TestScenePlayerScoreSubmission 14✅ 1❌ 12s
osu.Game.Tests.Visual.UserInterface.TestSceneFirstRunSetupOverlay 8✅ 1❌ 12s

❌ osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope

✅ TestAlwaysHidden
✅ TestConstructor
✅ TestVisibleAfterComboBreak
❌ TestVisibleDuringBreak
	"wait for end of break" timed out

❌ osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModRelax

✅ TestConstructor
✅ TestGameCursorHidden
❌ TestModRelax
	"test passed" timed out

❌ osu.Game.Rulesets.Catch.Tests.TestSceneCatchModHidden

✅ TestConstructor
❌ TestJuiceStream
	System.InvalidOperationException : Sequence contains no elements

❌ osu.Game.Rulesets.Mania.Tests.Mods.TestSceneManiaModFadeIn

✅ TestConstructor
✅ TestMaxCoverageFullWidth
✅ TestMaxCoverageHalfWidth
✅ TestMinCoverageFullWidth
❌ TestMinCoverageHalfWidth
	"test passed" timed out
✅ TestNoCoverageDuringBreak

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModAutoplay

✅ TestConstructor
✅ TestCursorPositionStoredToJudgement
✅ TestPerfectScoreOnShortSliderWithRepeat(20)
✅ TestPerfectScoreOnShortSliderWithRepeat(6.25f)
✅ TestSpmUnaffectedByRateAdjust
❌ TestSpmUnaffectedByTimeRamp
	"SPM is correct" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModDifficultyAdjust

✅ TestApproachRate1
✅ TestApproachRate10
✅ TestCircleSize1
✅ TestCircleSize10
✅ TestConstructor
❌ TestNoAdjustment
	"test passed" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight

✅ TestComboBasedSize(False)
✅ TestComboBasedSize(True)
✅ TestConstructor
✅ TestFollowDelay(120)
✅ TestFollowDelay(1200)
✅ TestFollowDelay(600)
✅ TestPlayfieldBasedSize
✅ TestSizeMultiplier(0.5f)
✅ TestSizeMultiplier(1.0f)
✅ TestSizeMultiplier(1.5f)
✅ TestSizeMultiplier(2.0f)
✅ TestSliderDimsOnlyAfterStartTime
❌ TestSliderDoesDimAfterStartTimeIfHitEarly
	"test passed" timed out
❌ TestSliderDoesDimAfterStartTimeIfHitLate
	"test passed" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModNoScope

✅ TestConstructor
✅ TestVisibleAfterComboBreak
❌ TestVisibleDuringBreak
	"wait for end of break" timed out
✅ TestVisibleDuringSpinner

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSingleTap

✅ TestConstructor
✅ TestInputAlternating
✅ TestInputAlternatingAtIntro
✅ TestInputAlternatingWithBreak
❌ TestInputSingular
	"test passed" timed out

❌ osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSpunOut

✅ TestConstructor
✅ TestSpinnerAutoCompleted
✅ TestSpinnerGetsNoBonusScore
❌ TestSpinRateUnaffectedByMods(null)
	"test passed" timed out
❌ TestSpinRateUnaffectedByMods(osu.Game.Rulesets.Osu.Mods.OsuModDoubleTime)
	"test passed" timed out
❌ TestSpinRateUnaffectedByMods(osu.Game.Rulesets.Osu.Mods.OsuModHalfTime)
	"test passed" timed out

❌ osu.Game.Rulesets.Osu.Tests.TestSceneCursorParticles

✅ TestConstructor
❌ TestLegacyBreakParticles
	"wait for break end" timed out
❌ TestLegacyKiaiParticles
	"wait for slider tracking" timed out

❌ osu.Game.Tests.Visual.Gameplay.TestSceneFailJudgement

❌ TestCatch
	"player is playing" timed out
✅ TestConstructor
❌ TestMania
	"player is playing" timed out
✅ TestOsu
✅ TestTaiko

❌ osu.Game.Tests.Visual.Gameplay.TestScenePlayerScoreSubmission

✅ TestConstructor
✅ TestNoSubmissionOnCustomRuleset(10)
✅ TestNoSubmissionOnCustomRuleset(null)
✅ TestNoSubmissionOnEmptyExit
✅ TestNoSubmissionOnEmptyFail
✅ TestNoSubmissionOnExitWithNoToken
✅ TestNoSubmissionOnLocalBeatmap
✅ TestNoSubmissionOnResultsWithNoToken
✅ TestNoSubmissionWithModsOfDifferentRuleset
✅ TestSubmissionForConvertedBeatmap
✅ TestSubmissionForDifferentRuleset
✅ TestSubmissionOnExit
✅ TestSubmissionOnExitDuringImport
❌ TestSubmissionOnFail
	"wait for submission" timed out
✅ TestSubmissionOnResults

❌ osu.Game.Tests.Visual.UserInterface.TestSceneFirstRunSetupOverlay

✅ TestBackButton(False)
✅ TestBackButton(True)
✅ TestBasic
✅ TestClickAwayToExit
✅ TestConstructor
✅ TestDoesntOpenOnSecondRun
✅ TestOverlayRunsToFinish(False)
❌ TestOverlayRunsToFinish(True)
	"step through" timed out
✅ TestResumeViaNotification

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModNoScope ► TestVisibleDuringBreak

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "wait for end of break" timed out
Raw output
"wait for end of break" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Catch.Tests.Mods.TestSceneCatchModRelax ► TestModRelax

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 40 in osu.Game.Rulesets.Catch.Tests/TestSceneCatchModHidden.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Catch.Tests.TestSceneCatchModHidden ► TestJuiceStream

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  System.InvalidOperationException : Sequence contains no elements
Raw output
System.InvalidOperationException : Sequence contains no elements
   at System.Linq.ThrowHelper.ThrowNoElementsException()
   at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
   at osu.Game.Rulesets.Catch.Tests.TestSceneCatchModHidden.<TestJuiceStream>b__0_0() in /Users/runner/work/osu/osu/osu.Game.Rulesets.Catch.Tests/TestSceneCatchModHidden.cs:line 40
   at osu.Game.Tests.Visual.ModTestScene.<TearDownSteps>b__7_0() in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/ModTestScene.cs:line 37
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Mania.Tests.Mods.TestSceneManiaModFadeIn ► TestMinCoverageHalfWidth

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModAutoplay ► TestSpmUnaffectedByTimeRamp

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "SPM is correct" timed out
Raw output
"SPM is correct" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModDifficultyAdjust ► TestNoAdjustment

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight ► TestSliderDoesDimAfterStartTimeIfHitEarly

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModFlashlight ► TestSliderDoesDimAfterStartTimeIfHitLate

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModNoScope ► TestVisibleDuringBreak

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "wait for end of break" timed out
Raw output
"wait for end of break" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSingleTap ► TestInputSingular

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.Mods.TestSceneOsuModSpunOut ► TestSpinRateUnaffectedByMods(null)

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "test passed" timed out
Raw output
"test passed" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)