Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix held gameplay keys stuck after pausing and resuming #28954

Merged
merged 5 commits into from
Jul 20, 2024

Merge branch 'master' into fix-pause-input-handling

401c0fe
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix held gameplay keys stuck after pausing and resuming #28954

Merge branch 'master' into fix-pause-input-handling
401c0fe
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Linux, MultiThreaded) failed Jul 20, 2024 in 0s

5992 passed, 1 failed and 52 skipped

Tests failed

❌ TestResults-Linux-MultiThreaded.trx

6045 tests were completed in 1398s with 5992 passed, 1 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen 21✅ 1❌ 22s

❌ osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen

✅ TestAudioLeadIn
✅ TestConstructor
✅ TestDelayedStart
✅ TestGameplayRateAdjust
✅ TestGeneral(1)
✅ TestGeneral(4)
✅ TestGeneral(9)
✅ TestIntroStoryboardElement
❌ TestMostInSyncUserIsAudioSource
	assertOnePlayerNotMuted
✅ TestMultipleStartRequests
✅ TestPlayersCatchUpAfterFallingBehind
✅ TestPlayersContinueWhileOthersBuffer
✅ TestPlayersDoNotStartSimultaneouslyIfBufferingForMaximumStartDelay
✅ TestPlayersLeaveWhileSpectating
✅ TestPlayersMustStartSimultaneously
✅ TestSpectatingDuringGameplay
✅ TestSpectatingDuringGameplayWithLateFrames
✅ TestSpectatorPlayerInteractiveElementsHidden
✅ TestTeamDisplay
✅ TestTeams(16)
✅ TestTeams(2)
✅ TestTimeDoesNotProgressWhileAllPlayersPaused

Annotations

Check failure on line 0 in TestResults-Linux-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, MultiThreaded)

osu.Game.Tests.Visual.Multiplayer.TestSceneMultiSpectatorScreen ► TestMostInSyncUserIsAudioSource

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
  assertOnePlayerNotMuted
Raw output
assertOnePlayerNotMuted
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()