Save grid settings to beatmap via IBeatmap #29001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really struggle to see the sense in PRing known broken solutions, where the underlying issues are being fixed by other unreviewed PRs (#20883 is open, and #28473 is open, and #23418 is open), the outcome of which may make this PR invalid or obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of #28973 without using
BeatmapInfo(see #28473)Moves GridSize from
BeatmapInfotoIBeatmap, and adds GridRotation, GridStartPositionX, GridStartPositionY, and GridTypeGridType does save to the
.osufile, but does not load properly when opening the map in the editor. I was unable to determine why this happens.save-grid-ibeatmap.webm