Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect pre-empt time when auto-generating breaks #29021

Merged
merged 4 commits into from
Jul 24, 2024

Fix autogenerated breaks not invalidating on change to pre-empt time

c3062f9
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Respect pre-empt time when auto-generating breaks #29021

Fix autogenerated breaks not invalidating on change to pre-empt time
c3062f9
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded) failed Jul 23, 2024 in 0s

5998 passed, 1 failed and 52 skipped

Tests failed

❌ TestResults-macOS-MultiThreaded.trx

6051 tests were completed in 3459s with 5998 passed, 1 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneStoryboardSamplePlayback 10✅ 1❌ 25s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneStoryboardSamplePlayback

✅ TestConstructor
✅ TestStoryboardSamplesPlaybackWithRateAdjustMods(osu.Game.Rulesets.Osu.Mods.OsuModDoubleTime,1.5d)
✅ TestStoryboardSamplesPlaybackWithRateAdjustMods(osu.Game.Rulesets.Osu.Mods.OsuModDoubleTime,2)
✅ TestStoryboardSamplesPlaybackWithRateAdjustMods(osu.Game.Rulesets.Osu.Mods.OsuModHalfTime,0.5d)
✅ TestStoryboardSamplesPlaybackWithRateAdjustMods(osu.Game.Rulesets.Osu.Mods.OsuModHalfTime,0.75d)
✅ TestStoryboardSamplesPlaybackWithTimeRampMods(osu.Game.Rulesets.Mods.ModWindDown,0.99d,0.5d)
✅ TestStoryboardSamplesPlaybackWithTimeRampMods(osu.Game.Rulesets.Mods.ModWindDown,2,0.5d)
✅ TestStoryboardSamplesPlaybackWithTimeRampMods(osu.Game.Rulesets.Mods.ModWindUp,0.5d,2)
✅ TestStoryboardSamplesPlaybackWithTimeRampMods(osu.Game.Rulesets.Mods.ModWindUp,1.51d,2)
✅ TestStoryboardSamplesStopDuringPause
❌ TestStoryboardSamplesStopOnSkip
	"any storyboard samples playing" timed out

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneStoryboardSamplePlayback ► TestStoryboardSamplesStopOnSkip

Failed test found in:
  TestResults-macOS-MultiThreaded.trx
Error:
  "any storyboard samples playing" timed out
Raw output
"any storyboard samples playing" timed out
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /Users/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)