Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Beatmap not downloaded" tooltip hint not showing in online play #29115

Merged
merged 1 commit into from
Jul 26, 2024

Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge

9323f89
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix "Beatmap not downloaded" tooltip hint not showing in online play #29115

Fix "Beatmap not downloaded" tooltip hint not showing in daily challenge
9323f89
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Jul 26, 2024 in 0s

10262 passed, 2 failed and 74 skipped

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

10338 tests were completed in 2741s with 10262 passed, 2 failed and 74 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 33✅ 1❌ 7s
osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation 89✅ 1❌ 123s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✅ TestConstructor
✅ TestConstructor
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(1000,0)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(2000,0)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
❌ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
	check first frame time: Expected: 0.0d +/- 100.0d
	  But was:  237.60409999999996d
	  Off by:   -237.60409999999996d
	
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)
✅ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

❌ osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation

✅ TestAttemptPlayBeatmapMissingFails
❌ TestAttemptPlayBeatmapMissingFails
	System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-7b31b1cb-ede0-4cf7-8800-4452cd1545fb\files\7\71\7144f4c05310d576375f316f08ab52397bc9f5f5c64a5bf53c8b7f73f4b07107' because it is being used by another process.
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestAttemptPlayBeatmapWrongHashFails
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapListingLinkSearchOnInitialOpen
✅ TestBeatmapOptionsInput
✅ TestBeatmapOptionsInput
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(False)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConfirmationRequiredToDiscardPlaylist(True)
✅ TestConstructor
✅ TestConstructor
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteAllScoresAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestDeleteScoreAfterPlaying
✅ TestExitGameFromSongSelect
✅ TestExitGameFromSongSelect
✅ TestExitImmediatelyAfterCompletion
✅ TestExitImmediatelyAfterCompletion
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithBackButton
✅ TestExitMultiWithEscape
✅ TestExitMultiWithEscape
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectAndImmediatelyClickLogo
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithClick
✅ TestExitSongSelectWithEscape
✅ TestExitSongSelectWithEscape
✅ TestExitWithHoldDisabled
✅ TestExitWithHoldDisabled
✅ TestExitWithOperationInProgress
✅ TestExitWithOperationInProgress
✅ TestFeaturedArtistDisclaimerDialog
✅ TestFeaturedArtistDisclaimerDialog
✅ TestForceExitWithOperationInProgress
✅ TestForceExitWithOperationInProgress
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesNotificationOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMainOverlaysClosesSettingsOverlay
✅ TestMenuMakesMusic
✅ TestMenuMakesMusic
✅ TestModSelectInput
✅ TestModSelectInput
✅ TestModsResetOnEnteringMultiplayer
✅ TestModsResetOnEnteringMultiplayer
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenModSelectOverlayUsingAction
✅ TestOpenOptionsAndExitWithEscape
✅ TestOpenOptionsAndExitWithEscape
✅ TestOverlayClosing
✅ TestOverlayClosing
✅ TestPresentBeatmapAfterDeletion
✅ TestPresentBeatmapAfterDeletion
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushMatchSubScreenAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestPushSongSelectAndPressBackButtonImmediately
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestQuickSkinEditorDoesntNukeSkin
✅ TestRetryCountIncrements
✅ TestRetryCountIncrements
✅ TestRetryFromResults
✅ TestRetryFromResults
✅ TestRetryImmediatelyAfterCompletion
✅ TestRetryImmediatelyAfterCompletion
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestSettingsViaHotkeyFromMainMenu
✅ TestShowMedalAtResults
✅ TestShowMedalAtResults
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(False)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongContinuesAfterExitPlayer(True)
✅ TestSongSelectBackActionHandling
✅ TestSongSelectBackActionHandling
✅ TestSongSelectScrollHandling
✅ TestSongSelectScrollHandling
✅ TestToolbarHiddenByUser
✅ TestToolbarHiddenByUser
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionAtSongSelect
✅ TestTouchScreenDetectionInGame
✅ TestTouchScreenDetectionInGame
✅ TestWaitForNextTrackInMenu
✅ TestWaitForNextTrackInMenu

Annotations

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False) 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  check first frame time: Expected: 0.0d +/- 100.0d
    But was:  237.60409999999996d
    Off by:   -237.60409999999996d
Raw output 
check first frame time: Expected: 0.0d +/- 100.0d
  But was:  237.60409999999996d
  Off by:   -237.60409999999996d

   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()

Check failure on line 276 in osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation ► TestAttemptPlayBeatmapMissingFails 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-7b31b1cb-ede0-4cf7-8800-4452cd1545fb\files\7\71\7144f4c05310d576375f316f08ab52397bc9f5f5c64a5bf53c8b7f73f4b07107' because it is being used by another process.
Raw output 
System.IO.IOException : The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\of-test-headless\TestSceneScreenNavigation-7b31b1cb-ede0-4cf7-8800-4452cd1545fb\files\7\71\7144f4c05310d576375f316f08ab52397bc9f5f5c64a5bf53c8b7f73f4b07107' because it is being used by another process.
   at System.IO.FileSystem.DeleteFile(String fullPath)
   at osu.Framework.Platform.NativeStorage.Delete(String path)
   at osu.Game.Tests.Visual.Navigation.TestSceneScreenNavigation.<>c__DisplayClass11_0.<TestAttemptPlayBeatmapMissingFails>b__4() in D:\a\osu\osu\osu.Game.Tests\Visual\Navigation\TestSceneScreenNavigation.cs:line 276
   at osu.Framework.Testing.Drawables.Steps.SingleStepButton.<.ctor>b__1_0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.UseTestSceneRunnerAttribute.AfterTest(ITest test)
   at NUnit.Framework.Internal.Commands.TestActionCommand.<>c__DisplayClass0_0.<.ctor>b__1(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__1()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)
View more details on GitHub Actions