Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover to expand mod customise panel #29136

Merged
merged 17 commits into from
Aug 7, 2024
Merged

Conversation

Cai1Hsu
Copy link
Contributor

@Cai1Hsu Cai1Hsu commented Jul 27, 2024

I didn't see anyone asking for this feature, but it feels fluent for me to select and adjust mods quickly.

The only place where I feel bad is that you have to click the header twice(collapse and expand the panel) to keep the panel expanded. I like that when hovering the header, you can click it to "pin" the panel so that it will not collapse when the cursor is left, and click it again to collapse it, as shown in the video at about 20s. but I didn't apply the patch in the commits because I don't know if people like it.

video demo

2024-07-27.18-02-19.mp4

@shiumano
Copy link
Contributor

Faster customization would be nice, but it seems a bit busy due to large panels opening and overlapping shadows. I would like a moment of grace.
Also, with touch input, where hover and click occur simultaneously, the concern about having to click twice on the header (collapsing and expanding the panel) is noticeable.

c600cd4d-29c3-4f5d-bdce-90a5f5de1b35.mp4

@peppy
Copy link
Sponsor Member

peppy commented Jul 31, 2024

I like this on a conceptual level, but mobile obviously needs a fix.

@Cai1Hsu
Copy link
Contributor Author

Cai1Hsu commented Jul 31, 2024

Also, with touch input, where hover and click occur simultaneously, the concern about having to click twice on the header (collapsing and expanding the panel) is noticeable.

Thanks, I'm going to push a fix.

but it seems a bit busy due to large panels opening and overlapping shadows. I would like a moment of grace.

could you make it more explicit? any suggestion for improvement?

osu.Game/Overlays/Mods/ModCustomisationPanel.cs Outdated Show resolved Hide resolved
osu.Game/Overlays/Mods/ModCustomisationHeader.cs Outdated Show resolved Hide resolved
osu.Game/Overlays/Mods/ModCustomisationPanel.cs Outdated Show resolved Hide resolved
@Cai1Hsu Cai1Hsu requested a review from bdach August 3, 2024 15:06
peppy
peppy previously approved these changes Aug 6, 2024
@bdach bdach enabled auto-merge August 7, 2024 12:09
@bdach bdach merged commit 8d89751 into ppy:master Aug 7, 2024
8 of 9 checks passed
@Cai1Hsu Cai1Hsu deleted the hover-open-mod-customise branch August 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants