Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow closing the Mod customize header by click only when it was opened by click. #29459

Closed
wants to merge 2 commits into from

Conversation

cdwcgt
Copy link
Contributor

@cdwcgt cdwcgt commented Aug 16, 2024

related #29457

osu.development.2024-08-17.00-58-28_x264.mp4

I haven't tested the touch screen environment, I hope there is no problem

@Cai1Hsu
Copy link
Contributor

Cai1Hsu commented Aug 17, 2024

i've actually proposed this with a patch attached in #29136 but peppy didn't adopted it

maybe they will add it back if people like it

@bdach
Copy link
Collaborator

bdach commented Aug 19, 2024

I initially ignored this because it was after @peppy's pass so I wasn't going to question anything UX but now that this is open I will.

I find the click interaction on that dropdown generally strange. You can't actually click the dropdown open the first time, it'll always hover-open. Then you can click it to close it, and only then click it to open it.

I dunno. I suppose this does what it says but I'm not super sure I'd even keep being able to click the dropdown in.

@bdach bdach requested a review from peppy August 19, 2024 08:01
@shiumano
Copy link
Contributor

I haven't tested the touch screen environment, I hope there is no problem

In the meantime, there seems to be no problem with this.

@peppy
Copy link
Member

peppy commented Aug 20, 2024

I dunno. I suppose this does what it says but I'm not super sure I'd even keep being able to click the dropdown in.

Tend to agree. Removing click-ability would work fine, as long as mobile is adequately considered.

@cdwcgt
Copy link
Contributor Author

cdwcgt commented Aug 20, 2024

Removing click-ability would work fine, as long as mobile is adequately considered.

This basically means that if the touch (mouse) leaves the panel, the panel will automatically close, which will be a poor experience for adjusting the slider.
Because the cursor can easily leave the panel when adjusting the slider
and also need consider the mod's require configuration property (difficulty adjust)

@bdach
Copy link
Collaborator

bdach commented Aug 20, 2024

This basically means that if the touch (mouse) leaves the panel, the panel will automatically close, which will be a poor experience for adjusting the slider.

Well no it shouldn't. That is what "mobile [being] adequately considered" is supposed to mean.

@Joehuu
Copy link
Member

Joehuu commented Sep 2, 2024

Judging by the above comments, this is superseded by #29626 because it removes the click-ability.

This basically means that if the touch (mouse) leaves the panel, the panel will automatically close, which will be a poor experience for adjusting the slider.

That was a separate issue that was fixed by #29541.

@Joehuu Joehuu closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants