Add notification on daily challenge conclusion & start of new one #29188
Conversation
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day on #general. The notifications are constrained to the daily challenge screen only to not spam users who may not care.
|
idk how useful the notification is if you're supposed to be looking at the daily challenge screen anyway (and see the beatmaps switch) |
|
The beatmap doesn't switch if you stay on the screen. |
| var roomRequest = new GetRoomRequest(change.NewValue.Value.RoomID); | ||
|
|
||
| roomRequest.Success += room => | ||
| { | ||
| waitForNextChallengeNotification?.Close(false); | ||
| notificationOverlay?.Post(new NewDailyChallengeNotification(room)); | ||
| }; | ||
| API.Queue(roomRequest); |
There was a problem hiding this comment.
Thoughts on having this notification appear even if you aren't on the daily challenge screen?
There was a problem hiding this comment.
See last line of OP:
The notifications are constrained to the daily challenge screen only to not spam users who may not care.
I'd rather avoid accusations of us 'railroading' users into this feature, but maybe I'm overly sensitive.
There was a problem hiding this comment.
fair i guess. we'll see if people request it :)
There was a problem hiding this comment.
Maybe only show for those who participated?
The current behavior doesn't work for people who log in straight at 0 UTC, when the button doesn't show.
There was a problem hiding this comment.
I'm honestly thinking the vast majority of users are not going to be annoyed by a notification once a day at a specific time of day and we should just go for it and wait for complaints, rather than the other way around.
Obviously only for the "new daily challenge" notification, not the other one.
I'm also fine with a toggle for this being added, something like "Receive notifications for game-wide events"
There was a problem hiding this comment.
Ok well I'll have a go I guess, although now that I think about it figuring out a place to put the notification logic may prove to be a right pain in the ass.
There was a problem hiding this comment.
I've done this in 1b57a2a. No toggle for now unless you think it is imperative for one to exist.
Not sure you'll like the placement, but it does work globally because of some implementation details (even if the button is offscreen, the bindable change callbacks fire, because that stuff is being invoked from MetadataClient which is everpresent).
|
I would love to have the notification being available everywhere! If you don't want to spam people who don't care (which I think is fine since it's just 2 notifications only if they're on during that moment), a setting that would allow them to turn it off would be nice. Edit: maybe a good compromise would be show the notification for the daily challenge ending only on the daily challenge screen, while having the daily challenge starting notification be global. |
|
@bdach can you confirm you're okay with the changes I made? if so i'll bundle this in a release today. |
|
They seem fine looking at source. |
2024-07-29.14-27-39.mp4
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day on #general.
The notifications are constrained to the daily challenge screen only to not spam users who may not care.