Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification on daily challenge conclusion & start of new one #29188

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Add notification on daily challenge conclusion & start of new one #29188

merged 9 commits into from
Jul 31, 2024

Commits on Jul 29, 2024

  1. Add notification on daily challenge conclusion & start of new one 

    Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.

The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
    @bdach
    bdach committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b46f3c9 View commit details
    Browse the repository at this point in the history

  2. Fix tests maybe

    @bdach
    bdach committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b77a10b View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Attempt to fix tests more

    @bdach
    bdach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a05f810 View commit details
    Browse the repository at this point in the history

  2. Show new daily challenge notification globally

    @bdach
    bdach committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1b57a2a View commit details
    Browse the repository at this point in the history

  3. Remove unused local variable

    @peppy
    peppy committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d5f9173 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into daily-challenge/better-messaging

    @peppy
    peppy committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d75c170 View commit details
    Browse the repository at this point in the history

  5. Fix test failure due to TestMetadataClient providing null statistic… 

    …s array
    @peppy
    peppy committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5ebb5ad View commit details
    Browse the repository at this point in the history

  6. Reword notification text slightly

    @peppy
    peppy committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bdc465e View commit details
    Browse the repository at this point in the history

  7. Allow notification of new strings

    @peppy
    peppy committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    e77489f View commit details
    Browse the repository at this point in the history