Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix context menus sometimes not being clickable at song select #29394

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix context menus sometimes not being clickable at song select #29394

merged 1 commit into from
Aug 12, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Aug 12, 2024

Closes #21602.

Seems fine in basic testing.

@bdach bdach self-requested a review August 12, 2024 11:40
bdach
bdach approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer is still broken as per #28344, but we can leave that for later, so as long as tests don't fail, seems fine

@bdach bdach merged commit acc7757 into ppy:master Aug 12, 2024
13 checks passed
@peppy peppy deleted the fix-song-select-context-menu-click branch August 13, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:song-select size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI layer issue for collection assignment
2 participants
@peppy @bdach