Add shadow around break overlay middle content to make sure it remains visible #29615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a bright background for testing overlay display.
I didn't really want to move the cursor in front of the HUD, but we face a bit of an impossible scenario otherwise (it should definitely be in front of the break overlay for visibility). So I'll deal with it for now.
1 task
bdach
reviewed
Aug 27, 2024
Comment on lines
+473
to
+474
| // display the cursor above some HUD elements. | ||
| DrawableRuleset.Cursor?.CreateProxy() ?? new Container(), |
There was a problem hiding this comment.
I guess I understand why this change was made but I will note that it leads to functional differences, namely that the cursor will now be above all HUD elements, not just some of them:
| master | this PR |
|---|---|
 |
 |
(see top left area on the screenshots above - on the left, the cursor is underneath the translucent wedge, and on the right it is not).
Was this particular behaviour change intentional or not?
There was a problem hiding this comment.
Aware, and touched on this in the commit description of abdbe51. I don't have a better solution right now. The visual design intention was to keep the cursor underneath the HUD though.
bdach
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29599.