Base DrawableTaikoHitObject Implementation #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e4ed82.
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
This was referenced Mar 20, 2017
smoogipoo
changed the title
smoogipoo
changed the title
…wable Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
peppy
reviewed
Mar 22, 2017
|
|
||
| namespace osu.Game.Modes.Taiko.Objects.Drawable | ||
| { | ||
| public class DrawableTaikoHitObject : DrawableHitObject<TaikoHitObject, TaikoJudgementInfo> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Mar 22, 2017
| LifetimeEnd = HitObject.StartTime + HitObject.PreEmpt; | ||
|
|
||
| // Todo: Remove (suppresses Resharper) | ||
| AccentColour = Color4.White; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
peppy
reviewed
Mar 22, 2017
|
|
||
| protected override TaikoJudgementInfo CreateJudgementInfo() => new TaikoJudgementInfo(); | ||
|
|
||
| protected override void UpdateState(ArmedState state) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…f added without a clock).
…wable Conflicts: osu.Game.Modes.Taiko/Objects/Drawable/DrawableTaikoHit.cs osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
This was referenced Feb 1, 2022
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial base DrawableTaikoHitObject.