Drawable Bash Implementation (Input only) #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
smoogipoo
changed the title
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
Conflicts: osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj
… to their hierarchy themselves. CreateCircle() lends itself to a few issues: - It can't be used for drum roll ticks unless it returned a Container instead, at which point the method loses its meaning, and I would rather that constructed in the ctor. - Writing `return Accented ? new AccentedCirclePiece() : new CirclePiece()` in two places as the body of this method feels wrong - it's something I would expect to be taken care of in the base DrawableTaikoHitObject, but that leads back to #1. - Swells don't have an AccentedCirclePiece, so #2 becomes more problematic.
peppy
reviewed
Mar 25, 2017
| /// A list of keys which this HitObject will accept. These are the standard Taiko keys for now. | ||
| /// These should be moved to bindings later. | ||
| /// </summary> | ||
| private List<Key> validKeys { get; } = new List<Key>(new[] { Key.D, Key.F, Key.J, Key.K }); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Conflicts: osu.Game.Modes.Taiko/Objects/Drawable/DrawableTaikoHitObject.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prereqs:
Basic bash drawable. Note: This doesn't contain the actual "drawable" part of the objects just yet - I wanted to push this out before that since it's already getting pretty big. A lot of this code is a combination of both the old taiko branch and osu-stable.