Taiko scoreprocessing #545
Conversation
Conflicts: osu.Game.Modes.Taiko/TaikoScoreProcessor.cs
| /// This is legacy and should be fixed, but is kept as is for now for compatibility. | ||
| /// </para> | ||
| /// </summary> | ||
| private const double hp_hit_good_max = hp_hit_good * 8; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| @@ -43,12 +44,15 @@ private TaikoHitObject convertHitObject(HitObject original) | |||
| IHasRepeats repeatsData = original as IHasRepeats; | |||
| IHasEndTime endTimeData = original as IHasEndTime; | |||
|
|
|||
| bool isFinisher = ((original.Sample?.Type ?? SampleType.None) & SampleType.Finish) > 0; | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| private double accuracyScore => accuracy_portion_max * Math.Pow(Accuracy, 3.6) * totalHits / maxTotalHits; | ||
|
|
||
| /// <summary> | ||
| /// The final bonus score. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
|
||
| protected override void UpdateCalculations(TaikoJudgement newJudgement) | ||
| { | ||
| var tickJudgement = newJudgement as TaikoDrumRollTickJudgement; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| maxComboPortion = comboPortion; | ||
| } | ||
|
|
||
| protected override void UpdateCalculations(TaikoJudgement newJudgement) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| var tickJudgement = newJudgement as TaikoDrumRollTickJudgement; | ||
|
|
||
| // Don't consider ticks as a type of hit that counts towards map completion | ||
| if (tickJudgement == null) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I think this is an okay compromise because hp_hit_great doesn't use linear interpolation here. I am tentative on this change, but I need to code up the rest of taiko before I can test this further.
Prereqs:
I didn't really want to derive
Hitonce more forHitFinisher(which would add no additional properties), and realized it could be used in the future for other hit objects as well, so I added a property to TaikoHitObject.This'll also be eventually used for actually getting the visual representation of these base hitobjects.
The calculations right now should be equivalent to osu!stable for the purpose of TWC, although we should look at simplifying it uniformly in the future.