Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async#job#connect #41

Merged
merged 4 commits into from
Dec 30, 2020
Merged

Add async#job#connect #41

merged 4 commits into from
Dec 30, 2020

Conversation

mattn
Copy link
Collaborator

@mattn mattn commented Dec 28, 2020

Now I could implement tcp feature on vim-lsp with async.vim. I'll send another pull-request to enable this.

augroup vim_lsp_settings_godot
  au!
  LspRegisterServer {
      \ 'name': 'godot',
      \ 'tcp': {server_info->lsp_settings#get('godot', 'tcp', '127.0.0.1:6008')},
      \ 'root_uri':{server_info->lsp_settings#get('godot', 'root_uri', lsp_settings#root_uri('godot'))},
      \ 'initialization_options': lsp_settings#get('godot', 'initialization_options', v:null),
      \ 'allowlist': lsp_settings#get('godot', 'allowlist', ['gdscript3', 'gdscript']),
      \ 'blocklist': lsp_settings#get('godot', 'blocklist', []),
      \ 'config': lsp_settings#get('godot', 'config', lsp_settings#server_config('godot')),
      \ 'workspace_config': lsp_settings#get('godot', 'workspace_config', {}),
      \ 'semantic_highlight': lsp_settings#get('godot', 'semantic_highlight', {}),
      \ }
augroup END

prabirshrestha/vim-lsp#469
prabirshrestha/vim-lsp#928
mattn/vim-lsp-settings#338

@mattn
Copy link
Collaborator Author

mattn commented Dec 28, 2020

I'll add test.

Copy link
Owner

@prabirshrestha prabirshrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good feel free to merge.

We can tackle neovim separately. It might be simple as just this.

function! s:on_data(id, data, event) abort
endfunction
call sockconnect('tcp', 'github.com:80', { 'on_data': function('s:on_data') })

@mattn
Copy link
Collaborator Author

mattn commented Dec 29, 2020

Sorry, I'm not familier to neovim. Can I merge this without neovim support?

@prabirshrestha
Copy link
Owner

Yes. We can merge this without neovim support.

@mattn
Copy link
Collaborator Author

mattn commented Dec 30, 2020

I'll merge this. Anyone, please add nvim support in later.

@mattn mattn merged commit 36e97f0 into prabirshrestha:master Dec 30, 2020
@mattn mattn deleted the tcp branch December 30, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants