Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tcp feature #985

Merged
merged 5 commits into from
Dec 31, 2020
Merged

Add tcp feature #985

merged 5 commits into from
Dec 31, 2020

Conversation

mattn
Copy link
Collaborator

@mattn mattn commented Dec 28, 2020 •
edited
Loading

@mattn
Copy link
Collaborator Author

mattn commented Dec 28, 2020

I'll do AsyncEmbed again after prabirshrestha/async.vim#41 will be merged.

prabirshrestha
prabirshrestha approved these changes Dec 28, 2020
View reviewed changes
Copy link
Owner

@prabirshrestha prabirshrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. added few comments in async.vim pr instead.

@prabirshrestha
Copy link
Owner

We need to also update the doc example.

@mattn
Copy link
Collaborator Author

mattn commented Dec 30, 2020

Cause of failing test seems to not related on this PR.
image

@mattn mattn mentioned this pull request Dec 31, 2020
Merged
@mattn mattn merged commit ee854b4 into master Dec 31, 2020
@mattn mattn deleted the tcp branch December 31, 2020 16:29
@mattn mattn mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabirshrestha prabirshrestha prabirshrestha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattn @prabirshrestha