Merge pull request #245 from practo/fix-244

Extra columns should come before
practo · Jul 14, 2021 · c1947e4 · c1947e4
2 parents 90a8223 + 379aeda
commit c1947e4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/controllers/redshiftsink_controller.go b/controllers/redshiftsink_controller.go
@@ -73,7 +73,7 @@ type RedshiftSinkReconciler struct {
 }
 
 const (
-	MaxTopicRelease = 50
+	MaxTopicRelease = 5
 )
 
 // +kubebuilder:rbac:groups=tipoca.k8s.practo.dev,resources=redshiftsinks,verbs=get;list;watch;create;update;patch;delete

diff --git a/pkg/transformer/debezium/schema.go b/pkg/transformer/debezium/schema.go
@@ -491,10 +491,8 @@ func (c *schemaTransformer) transformSchemaValue(jobSchema string,
 		}
 	}
 
-	// add extra columns (length columns)
-	for _, extraColumn := range extraColumns {
-		redshiftColumns = append(redshiftColumns, extraColumn)
-	}
+	// keep extra columns as first column to fix #244
+	redshiftColumns = append(extraColumns, redshiftColumns...)
 
 	table := redshift.Table{
 		Name:    d.tableName(),
-Original file line number
+Diff line change
@@ Expand Up / @@ -73,7 +73,7 @@ type RedshiftSinkReconciler struct { @@
     }
     const (
-    	MaxTopicRelease = 50
+    	MaxTopicRelease = 5
     )
     // +kubebuilder:rbac:groups=tipoca.k8s.practo.dev,resources=redshiftsinks,verbs=get;list;watch;create;update;patch;delete
@@ Expand Down @@