Extra columns should come before #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is backward incompatible for text_length feature in masking
Status update calls fail when many are updated together #246
|
Released image for this have tag: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
Problem
Currently new columns added at source breaks migration for tables having extra columns like
length_keysandmobile_keys.Solution
After this change extra columns will be the first columns instead of the last ones. This was done so that there are no migration failures when new columns are added at source.
And if any new extra column is added in masking, it will any way recreate the table in reload group, which already works!
Note: This is a backward incompatible change for all tables using
length_keysandmobile_keys. These tables needs to be reloaded.