Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISqliteConnection should be derived from IDisposable #1175

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

csm101
Copy link
Contributor

@csm101 csm101 commented Jun 21, 2023

It's a minor fix, but if ISqliteConnection is not declared as a IDisposable interface, It can't be used with the "using" c# pattern.

I mean, this code, before this modification would not compile:

using (ISQLiteConnection conn = MyConnectionFactory.GetConnection())
{
    ..... // use conn
}

I also added to .gitignore the project configuration files created by ncrunch (see https://www.ncrunch.net/)

…be used with the "using" c# construct

(also: added ncrunch files to .gitignore)
@csm101 csm101 mentioned this pull request Jun 21, 2023
Copy link
Owner

@praeclarum praeclarum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@praeclarum praeclarum merged commit 8d28c7c into praeclarum:master Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants