Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISqliteConnection should be derived from IDisposable #1175

Merged
merged 1 commit into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,6 @@ paket-files/
# CodeRush
.cr/

# NCrunch
*.ncrunchsolution
*.ncrunchproject
3 changes: 1 addition & 2 deletions src/SQLite.cs
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public enum CreateFlags
FullTextSearch4 = 0x200
}

public interface ISQLiteConnection
public interface ISQLiteConnection : IDisposable
{
Sqlite3DatabaseHandle Handle { get; }
string DatabasePath { get; }
Expand Down Expand Up @@ -215,7 +215,6 @@ CreateTablesResult CreateTables<T, T2, T3, T4, T5> (CreateFlags createFlags = Cr
int Delete (object primaryKey, TableMapping map);
int DeleteAll<T> ();
int DeleteAll (TableMapping map);
void Dispose ();
int DropTable<T> ();
int DropTable (TableMapping map);
void EnableLoadExtension (bool enabled);
Expand Down