Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if Earmark.Context.clear/1 behaves properly #166

Closed
RobertDober opened this issue Nov 26, 2017 · 1 comment
Closed

Check if Earmark.Context.clear/1 behaves properly #166

RobertDober opened this issue Nov 26, 2017 · 1 comment
Assignees
@RobertDober
Labels
bug
Milestone
1.2.4

Comments

@RobertDober
Copy link
Collaborator

Quoting @asummers from PR #165

While doing so, I noticed Earmark.Context.clear/1 was not piping the context through to put_in/3 so it was losing the clearing of value. Not sure what bugs that caused for others, but I'm not sure that has worked properly.
@RobertDober RobertDober added this to the 1.2.4 milestone Nov 26, 2017
@RobertDober RobertDober self-assigned this Nov 26, 2017
@RobertDober RobertDober changed the title Check if armark.Context.clear/1 behaves properly Check if Earmark.Context.clear/1 behaves properly Nov 26, 2017
@RobertDober
Copy link
Collaborator Author

Fixed in #165

RobertDober added a commit that referenced this issue Nov 27, 2017
@RobertDober
Added explicit reference to #166, which was fixed by asummers in #165
1bbd40a
RobertDober added a commit that referenced this issue Nov 27, 2017
@RobertDober
Fixed bug in bugfix of #166
5cfcb73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertDober RobertDober

Labels
bug
Projects
None yet
Milestone
1.2.4
Development

No branches or pull requests
1 participant
@RobertDober