-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typespec fixes + Fix to Earmark.Context.clear/1 #165
Conversation
Had an extra key passed by a caller, which caused the type check to fail.
lib/earmark/context.ex
Outdated
@type t :: %__MODULE__{ | ||
options: Earmark.Options.t, | ||
links: map(), | ||
rules: Keyword.t(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this can be nil
as well?
@asummers I'll have a look concerning your remark and merge as soon as I can fix Travis (probabaly just a relaunch needed) |
It's possible we want to open a follow-up issue to add a unit or regression test for the |
Also looks like Travis is good again. 🤖 🎉 |
Is it possible for us to push a new patch version to hex? |
No this can only be done by @pragdave , anticipating his question and also not having finished the milestone I would like to ask though, what value do these type fixes give you in production? Could you supress your warnings in your projects with something like that
That all said, if it is really important I can of course ask Dave. |
We’re using the ignore-warnings but there is an actual bug fixed in this PR and not just the type specs. |
oops sorry to be so superficial... trying not to ignore you as your help is appreciated, then running too fast. I'll ask @pragdave tonight! |
No worries, I understand! |
Ok there was a bug in the code, I fixed it, and asked for a release. |
Unfortunately @pragdave could not publish the hex package
I will need to find some time to look into this but maybe you could help to speed things up. |
@asummers @joshsmith Dave released 1.2.4 tonight 👍 <3 🎆 |
Added some
@type
s and resolved a few typspec errors (Map.t
not existing, e.g.).While doing so, I noticed
Earmark.Context.clear/1
was not piping the context through toput_in/3
so it was losing the clearing ofvalue
. Not sure what bugs that caused for others, but I'm not sure that has worked properly.