Typescript definition missing important properties or has properties that should be optional. #133
Labels
Comments
mseddon
changed the title
|
Yikes! Are you able to do a quick PR to fix those? |
|
not right now :( I can get it at the weekend but atm I am hitting a deadline wall :/ |
|
easiest solution would be to remove the typings property from |
developit
added a commit
that referenced
this issue
Jan 30, 2017
|
patched in 2.4.1. |
|
Nice! Will try and get that cleaned up at the end of the week. |
|
Any updates on this? I thought I was losing my mind when my project couldn't find the definition file until I tracked it down to the "x-typings" and then found this issue through the git blame commit hash to disable the typings temporarily. Makes sense now, haha. |
|
It would be nice to have the type definitions back. I can try and add them. |
pspeter3
added a commit
to pspeter3/preact-router
that referenced
this issue
Mar 30, 2017
This addresses the issues in preactjs#133
Merged
Alexendoo
added a commit
to Alexendoo/preact-router
that referenced
this issue
Jun 8, 2017
it appears the issues in preactjs#133 were addressed but the typings file yet restored
Alexendoo
added a commit
to Alexendoo/preact-router
that referenced
this issue
Jun 8, 2017
Fixes errors present in strict mode Adds getCurrentUrl and route override definitions Adds a RoutableProps interface consumers can extend to implement a routable component Fixes the types of RouterProps, Route, Link (closes preactjs#133) Re-enables the typings file in package.json
developit
pushed a commit
that referenced
this issue
Jun 13, 2017
* Fix typescript definitions Fixes errors present in strict mode Adds getCurrentUrl and route override definitions Adds a RoutableProps interface consumers can extend to implement a routable component Fixes the types of RouterProps, Route, Link (closes #133) Re-enables the typings file in package.json * add generic over Route, RouteProps
happydev1237
added a commit
to happydev1237/Preact-router-example
that referenced
this issue
Mar 29, 2023
This addresses the issues in preactjs/preact-router#133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Causes huge walls of (invalid) errors in our codebase after upgrading to 2.4.0. I've taken to rm'ing
index.d.tsfor now :)The issues are:
Routerhas nohistoryprop.RouterArgs.matchesshould be optional.RouterArgs.urlshould be optional.RouterArgs.pathshould be present.I think that's all, but don't have time atm to try to fix or dig deeper so there may be others.
The text was updated successfully, but these errors were encountered: