Fix typescript definitions #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes errors present in strict mode Adds getCurrentUrl and route override definitions Adds a RoutableProps interface consumers can extend to implement a routable component Fixes the types of RouterProps, Route, Link (closes preactjs#133) Re-enables the typings file in package.json
developit
approved these changes
Jun 13, 2017
| export function route(url: string, replace?: boolean): boolean; | ||
| export function route(options: { url: string; replace?: boolean }): boolean; |
There was a problem hiding this comment.
I think it allows both formats? Definitely supports route(url, replace).
|
Any chance of getting this published @developit 😄 |
|
Yup yup. |
|
ty! 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors present in strict mode
Adds getCurrentUrl and route override definitions
Adds a RoutableProps interface consumers can extend to implement a routable component
Fixes the types of RouterProps, Route, Link (closes #133)
Re-enables the typings file in package.json