Improve null placeholder DOM placement #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test is failing cuz when trying to find the sibling dom in `getDomSibling`, a parent is in the middle of diffing and it's `_children` prop is set to it's render result, which is not an array.
The `_parent` property is shared between oldVNode and newVNode in this situation so when traversing up oldVNode `_parent`, you reach a parent's newVNode. In other words, in `renderComponent` , `/* oldVNode */ assign({}, vnode)._children[0]._parent == /* newVNode */ vnode`
This reverts commit 2e6d800.
* fix failing test by defaulting to empty array * use correct import * apply different fix
|
Size Change: +93 B (0%) Total Size: 38.5 kB
ℹ️ View Unchanged
|
marvinhagemeister
approved these changes
Feb 17, 2020
JoviDeCroock
approved these changes
Feb 17, 2020
marvinhagemeister
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a Component went from rendering DOM to rendering
null, our child diffing algorithm would have to re-place all children after the DOM that was removed. This PR improves the diffing algorithm to detect when this has happened and continue diffing from the removed DOM node's sibling.Also reverts a change I made to a test in #2352 that invalidated the test.
Fixes #2350