Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating /compat/server exports to work with import/export syntax and webpack 5 #2873

Merged
merged 3 commits into from
Dec 25, 2020
Merged

Updating /compat/server exports to work with import/export syntax and webpack 5 #2873

merged 3 commits into from
Dec 25, 2020

Conversation

SomethingSexy
Copy link
Contributor

Fixes #2872

Allows webpack to properly import "./compat/server"

@coveralls
Copy link

coveralls commented Dec 19, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling dbf4a5e on SomethingSexy:master into 37a884c on preactjs:master.

developit
developit approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI failures are just the benchmarks not running on fork PRs.

@JoviDeCroock JoviDeCroock merged commit 264c5e5 into preactjs:master Dec 25, 2020
@marvinhagemeister marvinhagemeister mentioned this pull request Mar 12, 2021
Closed
@chmelevskij
Copy link

Hey, I think this PR brakes it for other tools. E.G. vitejs, since default has require, bundler with stricter semantics just throws require is not defined will try to make a better repro.

This was referenced Sep 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package Exports in package.json not including "import" for "./compat/server"
5 participants
@SomethingSexy @coveralls @chmelevskij @developit @JoviDeCroock