Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check preallocate new children array perf #4595

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

JoviDeCroock
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 6, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-10.02ms - +2.26ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +3% (-0.03ms - +0.56ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 11% - 14% (7.70ms - 10.57ms)
    preact-local vs preact-main
  • many-updates: slower ❌ 4% - 8% (0.67ms - 1.21ms)
    preact-local vs preact-main
  • replace1k: faster ✔ 0% - 4% (0.13ms - 2.66ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +3% (-0.13ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -5% - +0% (-1.64ms - +0.03ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 2% - 5% (0.62ms - 1.96ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: faster ✔ 23% - 23% (5.64ms - 5.64ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 6% - 9% (0.10ms - 0.14ms)
    preact-local vs preact-main
  • hydrate1k: faster ✔ 10% - 18% (1.11ms - 2.16ms)
    preact-local vs preact-main
  • many-updates: faster ✔ 16% - 17% (0.74ms - 0.76ms)
    preact-local vs preact-main
  • replace1k: faster ✔ 16% - 17% (0.57ms - 0.59ms)
    preact-local vs preact-main
  • text-update: slower ❌ 0% - 1% (0.00ms - 0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 16% - 16% (0.55ms - 0.57ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local938.77ms - 948.77ms-unsure 🔍
-1% - +0%
-10.02ms - +2.26ms
preact-main944.10ms - 951.21msunsure 🔍
-0% - +1%
-2.26ms - +10.02ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.21ms - 19.21ms-faster ✔
23% - 23%
5.64ms - 5.64ms
preact-main24.85ms - 24.85msslower ❌
29% - 29%
5.64ms - 5.64ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 17.13ms-unsure 🔍
-0% - +3%
-0.03ms - +0.56ms
preact-main16.54ms - 16.62msunsure 🔍
-3% - +0%
-0.56ms - +0.03ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.56ms-faster ✔
6% - 9%
0.10ms - 0.14ms
preact-main1.65ms - 1.68msslower ❌
7% - 9%
0.10ms - 0.14ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local63.94ms - 64.82ms-faster ✔
11% - 14%
7.70ms - 10.57ms
preact-main72.14ms - 74.88msslower ❌
12% - 16%
7.70ms - 10.57ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local9.68ms - 10.16ms-faster ✔
10% - 18%
1.11ms - 2.16ms
preact-main11.08ms - 12.02msslower ❌
11% - 22%
1.11ms - 2.16ms
-
many-updates
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4172
  • Commit: 2f5ca58

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.56ms - 16.76ms-slower ❌
4% - 8%
0.67ms - 1.21ms
preact-main15.46ms - 15.97msfaster ✔
4% - 7%
0.67ms - 1.21ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.77ms-faster ✔
16% - 17%
0.74ms - 0.76ms
preact-main4.50ms - 4.52msslower ❌
20% - 20%
0.74ms - 0.76ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local70.58ms - 71.92ms-faster ✔
0% - 4%
0.13ms - 2.66ms
preact-main71.58ms - 73.72msslower ❌
0% - 4%
0.13ms - 2.66ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-faster ✔
16% - 17%
0.57ms - 0.59ms
preact-main3.55ms - 3.56msslower ❌
19% - 20%
0.57ms - 0.59ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local31.48ms - 32.40ms-unsure 🔍
-2% - +2%
-0.66ms - +0.55ms
preact-main31.61ms - 32.39msunsure 🔍
-2% - +2%
-0.55ms - +0.66ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local36.30ms - 37.78ms-faster ✔
0% - 6%
0.01ms - 2.19ms
preact-main37.34ms - 38.94msunsure 🔍
-0% - +6%
+0.01ms - +2.19ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local27.26ms - 27.98ms-faster ✔
12% - 15%
3.67ms - 4.96ms
preact-main31.40ms - 32.47msslower ❌
13% - 18%
3.67ms - 4.96ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.96ms - 28.15ms-slower ❌
12% - 19%
3.01ms - 4.39ms
preact-main23.51ms - 24.20msfaster ✔
11% - 16%
3.01ms - 4.39ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.43ms - 26.89ms-slower ❌
11% - 18%
2.61ms - 4.13ms
preact-main22.60ms - 22.98msfaster ✔
10% - 15%
2.61ms - 4.13ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.96ms - 23.48ms-slower ❌
7% - 11%
1.51ms - 2.33ms
preact-main20.98ms - 21.62msfaster ✔
7% - 10%
1.51ms - 2.33ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 220
  • Built by: CI #4172
  • Commit: 2f5ca58

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.08ms - 2.21ms-unsure 🔍
-6% - +3%
-0.13ms - +0.06ms
preact-main2.11ms - 2.25msunsure 🔍
-3% - +6%
-0.06ms - +0.13ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.12ms-slower ❌
0% - 1%
0.00ms - 0.01ms
preact-main1.10ms - 1.11msfaster ✔
0% - 1%
0.00ms - 0.01ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.05ms - 33.55ms-unsure 🔍
-5% - +0%
-1.64ms - +0.03ms
preact-main33.30ms - 34.90msunsure 🔍
-0% - +5%
-0.03ms - +1.64ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.24ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.22ms - 1.22msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms
-
update10th1k
  • Browser: chrome-headless
  • Sample size: 130
  • Built by: CI #4172
  • Commit: 2f5ca58

duration

VersionAvg timevs preact-localvs preact-main
preact-local35.92ms - 36.91ms-faster ✔
2% - 5%
0.62ms - 1.96ms
preact-main37.25ms - 38.16msslower ❌
2% - 5%
0.62ms - 1.96ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.92ms - 2.94ms-faster ✔
16% - 16%
0.55ms - 0.57ms
preact-main3.49ms - 3.50msslower ❌
19% - 20%
0.55ms - 0.57ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Dec 6, 2024

Size Change: +29 B (+0.05%)

Total Size: 62.4 kB

Filename Size Change
dist/preact.js 4.71 kB +4 B (+0.08%)
dist/preact.min.js 4.73 kB +5 B (+0.11%)
dist/preact.min.module.js 4.73 kB +4 B (+0.08%)
dist/preact.min.umd.js 4.76 kB +5 B (+0.11%)
dist/preact.module.js 4.74 kB +6 B (+0.13%)
dist/preact.umd.js 4.78 kB +5 B (+0.1%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.06 kB
compat/dist/compat.umd.js 4.2 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 973 B
jsx-runtime/dist/jsxRuntime.module.js 947 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.617%. remained the same
when pulling 2f5ca58 on check-prealloc-perf
into 2d76a3b on main.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daaaamn

@JoviDeCroock JoviDeCroock merged commit b864138 into main Dec 6, 2024
15 checks passed
@JoviDeCroock JoviDeCroock deleted the check-prealloc-perf branch December 6, 2024 13:44
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants