Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.25.2 #4605

Merged
merged 1 commit into from
Dec 12, 2024
Merged

10.25.2 #4605

merged 1 commit into from
Dec 12, 2024

Conversation

JoviDeCroock
Copy link
Member

Notable

Revert unkeyed no-search (#4604, thanks @JoviDeCroock)

We noticed that there's a few unpleasant scenario's that could form from this change, we wanted to be on the safe side here and revert this for the time being. if you run into issues with swapping components placement wise in a list use the key property.

Fixes

Types

Performance

Maintenance

Copy link

github-actions bot commented Dec 12, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-5.14ms - +3.16ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.30ms - +0.17ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-1.01ms - +0.83ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -4% - +0% (-0.64ms - +0.06ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.77ms - +0.61ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +3% (-0.09ms - +0.07ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.09ms - +0.18ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +2% (-1.38ms - +0.62ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +5% (-0.31ms - +0.46ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local937.03ms - 943.58ms-unsure 🔍
-1% - +0%
-5.14ms - +3.16ms
preact-main938.74ms - 943.85msunsure 🔍
-0% - +1%
-3.16ms - +5.14ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.20ms - 19.21ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main19.20ms - 19.22msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.44ms - 16.75ms-unsure 🔍
-2% - +1%
-0.30ms - +0.17ms
preact-main16.49ms - 16.84msunsure 🔍
-1% - +2%
-0.17ms - +0.30ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.52ms - 1.55ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms
preact-main1.52ms - 1.53msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.98ms - 68.22ms-unsure 🔍
-1% - +1%
-1.01ms - +0.83ms
preact-main67.00ms - 68.37msunsure 🔍
-1% - +1%
-0.83ms - +1.01ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local9.92ms - 10.49ms-unsure 🔍
-3% - +5%
-0.31ms - +0.46ms
preact-main9.87ms - 10.39msunsure 🔍
-4% - +3%
-0.46ms - +0.31ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local17.70ms - 18.07ms-unsure 🔍
-4% - +0%
-0.64ms - +0.06ms
preact-main17.88ms - 18.47msunsure 🔍
-0% - +4%
-0.06ms - +0.64ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.79ms-unsure 🔍
-0% - +1%
-0.02ms - +0.02ms
preact-main3.76ms - 3.79msunsure 🔍
-1% - +0%
-0.02ms - +0.02ms
-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.09ms - 70.05ms-unsure 🔍
-1% - +1%
-0.77ms - +0.61ms
preact-main69.15ms - 70.14msunsure 🔍
-1% - +1%
-0.61ms - +0.77ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.99ms-unsure 🔍
-0% - +1%
-0.00ms - +0.03ms
preact-main2.96ms - 2.97msunsure 🔍
-1% - +0%
-0.03ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.40ms - 30.97ms-unsure 🔍
-2% - +1%
-0.53ms - +0.30ms
preact-main30.50ms - 31.10msunsure 🔍
-1% - +2%
-0.30ms - +0.53ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local35.31ms - 36.63ms-unsure 🔍
-3% - +2%
-1.07ms - +0.84ms
preact-main35.39ms - 36.78msunsure 🔍
-2% - +3%
-0.84ms - +1.07ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.58ms - 26.96ms-unsure 🔍
-2% - +1%
-0.42ms - +0.20ms
preact-main26.63ms - 27.12msunsure 🔍
-1% - +2%
-0.20ms - +0.42ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.01ms - 28.47ms-unsure 🔍
-5% - +2%
-1.44ms - +0.58ms
preact-main27.46ms - 28.87msunsure 🔍
-2% - +5%
-0.58ms - +1.44ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.25ms - 26.68ms-unsure 🔍
-5% - +3%
-1.31ms - +0.70ms
preact-main25.56ms - 26.98msunsure 🔍
-3% - +5%
-0.70ms - +1.31ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.62ms - 23.12ms-unsure 🔍
-2% - +1%
-0.37ms - +0.34ms
preact-main22.64ms - 23.13msunsure 🔍
-1% - +2%
-0.34ms - +0.37ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 110
  • Built by: CI #4194
  • Commit: f8650ab

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.96ms - 2.08ms-unsure 🔍
-5% - +3%
-0.09ms - +0.07ms
preact-main1.97ms - 2.08msunsure 🔍
-3% - +5%
-0.07ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local34.10ms - 34.31ms-unsure 🔍
-0% - +1%
-0.09ms - +0.18ms
preact-main34.07ms - 34.25msunsure 🔍
-1% - +0%
-0.18ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.22ms - 1.23ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.22ms - 1.22msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.01ms - 34.35ms-unsure 🔍
-4% - +2%
-1.38ms - +0.62ms
preact-main33.32ms - 34.80msunsure 🔍
-2% - +4%
-0.62ms - +1.38ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.91ms - 2.93ms-unsure 🔍
-1% - +0%
-0.02ms - +0.01ms
preact-main2.91ms - 2.93msunsure 🔍
-0% - +1%
-0.01ms - +0.02ms
-

tachometer-reporter-action v2 for CI

Copy link

Size Change: 0 B

Total Size: 62.3 kB

ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.13 kB
compat/dist/compat.module.js 4.06 kB
compat/dist/compat.umd.js 4.2 kB
debug/dist/debug.js 3.82 kB
debug/dist/debug.module.js 3.83 kB
debug/dist/debug.umd.js 3.9 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.7 kB
dist/preact.min.js 4.72 kB
dist/preact.min.module.js 4.72 kB
dist/preact.min.umd.js 4.74 kB
dist/preact.module.js 4.72 kB
dist/preact.umd.js 4.76 kB
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 973 B
jsx-runtime/dist/jsxRuntime.module.js 947 B
jsx-runtime/dist/jsxRuntime.umd.js 1.05 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.615%. remained the same
when pulling f8650ab on 10.25.2
into fcb8d7c on main.

@JoviDeCroock JoviDeCroock merged commit 2beb9f7 into main Dec 12, 2024
15 checks passed
@JoviDeCroock JoviDeCroock deleted the 10.25.2 branch December 12, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants