refactor: Silence Rollup warnings regarding source maps & use directives #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschristian
commented
Dec 31, 2024
Comment on lines
-156
to
+160
| // Silence Rollup's module-level directive warnings -- they're likely | ||
| // to all come from `node_modules` (RSCs) and won't be actionable. | ||
| if (warning.code === "MODULE_LEVEL_DIRECTIVE") return; | ||
| // Silence Rollup's module-level directive warnings re:"use client". | ||
| // They're likely to come from `node_modules` and won't be actionable. | ||
| if ( | ||
| warning.code === "MODULE_LEVEL_DIRECTIVE" && | ||
| warning.message.includes("use client") |
There was a problem hiding this comment.
I figure copying Vite's React plugin and restricting this to only use client is a good idea -- users should be warned if a use server shows up somewhere.
JoviDeCroock
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone mentioned this in Slack the other day. It appears as though any use of the
'use client'directive w/ sourcemaps enabled will trigger this warning, and do so per file -- react query & MUI (apparently) result in a lot of terminal spam as such.Reference: